fix(lsp): update documentation for unwraps#230
Merged
KyrylR merged 1 commit intoBlockstreamResearch:masterfrom Mar 13, 2026
Merged
fix(lsp): update documentation for unwraps#230KyrylR merged 1 commit intoBlockstreamResearch:masterfrom
KyrylR merged 1 commit intoBlockstreamResearch:masterfrom
Conversation
Collaborator
|
Rebase to main pls |
There was an error in the function signatures for `unwrap_left` and `unwrap_right` in the LSP documentation where the expected `Either` generic types were swapped. Also make it clearer exactly which type is used when we are unwrapping these values.
gerau
force-pushed
the
lsp/documentation
branch
from
dd1f546 to
ac7f280
Compare
Collaborator
|
ACK ac7f280; ran tests locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an error in the function signatures for
unwrap_leftandunwrap_rightin the LSP documentation where the expectedEithergeneric types were swapped.Also make it clearer exactly which type is used when we are unwrapping these values.