feat(settlement): rename routing MI lease version - #12
Merged
allyblockcast[bot] merged 1 commit intoAug 10, 2026
Merged
Conversation
Break the v1 signing preimage deliberately, move the routing envelope schema tag to routing_mi_version, and reject legacy leases. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Contributor
Author
|
🔗 Paperclip issue: BLO-24171 |
1 similar comment
Contributor
Author
|
🔗 Paperclip issue: BLO-24171 |
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 3e6de2e
Critical Issues (0)
Important Issues (0)
Suggestions (0)
Strengths
- The v2 domain separator, settlement version, and canonical
routing_mi_versionpreimage field move together, preserving lexicographic key order. DecodeSessionLeaserejects the oldroute_versionkey throughDisallowUnknownFields, andVerifyrejects v1 settlement versions before signature verification.- Focused verification passed:
go test ./settlement.
Recommended Action
- Safe to proceed with the coordinated v2 deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionLease.RouteVersion/route_versiontoRoutingMIVersion/routing_mi_versionPrecondition
Confirmed before implementation: organization-wide code search found no merged non-test verifier, and no Caddy/Helm/YAML configuration enables the merged signer capability. The only verifier consumer is in unmerged trafficcontrol PR #1274.
Verification
go test ./...also reaches an unrelated pre-existing failure infec/TestESIRangeFromRangeListBorderCase; the same failure reproduces on a cleanorigin/mainworktree.Risks
This intentionally invalidates every v1 signature. The multicast signer and trafficcontrol PR #1274 verifier mirror are being updated in lockstep.
Paperclip: https://paperclip.blockcast.net/BLO/issues/BLO-24171