docs(claude): weekly CLAUDE.md refresh 2026-07-27 - #21
Merged
Merged
Conversation
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Author
1 similar comment
Author
allyblockcast
approved these changes
Jul 27, 2026
allyblockcast
left a comment
allyblockcast
left a comment
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 70423b5
Looks good. The readiness guidance accurately reflects the merged Helm configuration from PR #20: API readiness uses /version, worker readiness uses /metrics, and /health remains the database-aware endpoint.
Strengths
- Keeps the repository guidance concise and scoped to the operational invariant.
- Explains the failure mode the probe choice prevents, rather than only recording endpoint names.
Recommended Action
Approve and merge.
kkroo
pushed a commit
that referenced
this pull request
Sep 10, 2026
The "Helm Operations" paragraph claimed "readiness remains DB-backed on
`/health`". That is false against the chart and contradicts the
"Helm Health Probes" section immediately below it.
Ground truth in helm/hindsight/values.yaml at this head:
- API readiness -> /version (values.yaml:53)
- worker readiness -> /metrics (values.yaml:156)
- the only /health probes are the optional TEI reranker/embeddings
sidecars on ports 8090/8091 (values.yaml:396-447) -- unrelated to
API/worker readiness.
values.yaml:49-50 states the intent directly: "Keep readiness on the
cheap process/version endpoint so DB pressure cannot cascade into kube
probe failures".
The claim was introduced by #16 (8df7368, 2026-08-25) and regressed the
fact established by #21 (ead5161, 2026-08-11). Left uncorrected it
would lead a reader to repoint readiness at /health, reintroducing the
DB-pressure -> probe-failure restart cascade that #15, #18, #20 and #21
were filed to remove.
Drops the false clause and cross-references the section below rather
than restating it. Liveness endpoints and the DB-pool/concurrency
sentence were verified correct and are unchanged.
Co-authored-by: Staff Engineer <staff-engineer@paperclip.blockcast.net>
Co-authored-by: Paperclip <noreply@paperclip.ing>
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
/version, worker/metrics, and/healthreserved for explicit database-aware checks. Traces to merged PR fix(helm): align Hindsight probes with DB pressure remediation #20.Pruned
CLAUDE.mdinstruction.Fixed
Uncertain — needs human review
docs/claude-weekly-refresh-20260727branch cannot exist because this repository has a top-leveldocsGit ref. This PR uses the establishedstaff-engineer/docs-...fallback, matching prior weekly refresh PR docs(claude): weekly CLAUDE.md refresh 2026-07-06 #16.Verification
CLAUDE.mdagainst PR fix(helm): align Hindsight probes with DB pressure remediation #20's merged diff.git diff --checkpasses.Paperclip: BLO-18402