Fix ImportError from private typing module members in Python 3.8 #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code imports
_UnionGenericAliasand_GenericAliasfrom thetypingmodule, which are private APIs not guaranteed to exist across Python versions. In Python 3.8, these members don't exist, causingImportError: cannot import name '_UnionGenericAlias' from 'typing'.Changes
_UnionGenericAliasand_GenericAliaswith public APIget_origintype(x) == _UnionGenericAlias or type(x) == _GenericAlias→get_origin(x) is not NoneBefore:
After:
This maintains compatibility with Python 3.8+ using only public typing APIs.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.