fix: scope keychain validation to wallet type#190
Merged
pranavjain97 merged 1 commit intomasterfrom Apr 27, 2026
Merged
Conversation
pranavjain97
changed the title
alextse-bg
previously approved these changes
Apr 20, 2026
Contributor
alextse-bg
left a comment
alextse-bg
left a comment
There was a problem hiding this comment.
lgtm, but CI is failing
Only validate commonKeychain for TSS wallets and pubkey for multisig wallets. Previously, sending an irrelevant commonKeychain param for a multisig wallet would trigger a misleading mismatch error instead of being ignored. - Reuse isTss variable to avoid calling multisigType() twice - Add tests for scoped validation and ignoring irrelevant params - Update existing TSS tests to send commonKeychain instead of pubkey Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pranavjain97
force-pushed
the
WCN-84-scope-keychain-validation
branch
from
acb8cc8 to
7133bdf
Compare
alextse-bg
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only validate commonKeychain for TSS wallets and pubkey for multisig wallets. Previously, sending an irrelevant commonKeychain param for a multisig wallet would trigger a misleading mismatch error instead of being ignored.