feat(wasm-utxo): fix zcash blake2b sighash for 256-byte outputs#257
Merged
feat(wasm-utxo): fix zcash blake2b sighash for 256-byte outputs#257
Conversation
A Zcash transaction with 8 P2SH outputs has a 256-byte outputs preimage (8 × 32 bytes each), which is an exact multiple of the 128-byte BLAKE2b block size. The old blake2b_256_personal in rust-bitcoin processed all complete blocks eagerly and left an empty buffer for finalize, causing a spurious all-zero final block and an incorrect sighash. This test signs such a transaction and verifies the signature, catching the regression in wasm-utxo's Zcash signing and verification path. Issue: BTC-0
Update miniscript dependency from bitgo.1 to bitgo.2, which includes the corresponding bitcoin crate update to 0.32.8-bitgo.2. Issue: BTC-0 Co-authored-by: llm-git <[email protected]>
lcovar
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update miniscript dependency from bitgo.1 to bitgo.2, which includes
the corresponding bitcoin crate update to 0.32.8-bitgo.2.
A Zcash transaction with 8 P2SH outputs has a 256-byte outputs preimage
(8 × 32 bytes each), which is an exact multiple of the 128-byte BLAKE2b
block size. The old blake2b_256_personal in rust-bitcoin processed all
complete blocks eagerly and left an empty buffer for finalize, causing a
spurious all-zero final block and an incorrect sighash.
Added regression test that signs such a transaction and verifies the
signature, catching the regression in wasm-utxo's Zcash signing and
verification path.
Issue: BTC-0