feat(sdk-core): bulk TRX resource delegation SDK + Express layer by bhavidhingra · Pull Request #8572 · BitGo/BitGoJS

bhavidhingra · 2026-04-20T09:06:10Z

Summary

Resource Delegation

Adds buildResourceDelegations, sendResourceDelegation, sendResourceDelegations to Wallet and IWallet
buildResourceDelegations: POSTs to /:coin/wallet/:id/delegateResources/build, post-processes prebuilds
sendResourceDelegation: dispatches per wallet type — TSS → sendManyTxRequests, custodial → initiateTransaction, hot → prebuildAndSignTransaction + submitTransaction
sendResourceDelegations: validates passphrase, builds all, sends sequentially, collects { success, failure }
Adds typed Express route (PostDelegateResources) and handleV2DelegateResources handler with partial-success 202/400 response logic

Resource Undelegation

Adds buildResourceUndelegations, sendResourceUndelegation, sendResourceUndelegations to Wallet and IWallet — mirrors delegation API exactly
buildResourceUndelegations: POSTs to /:coin/wallet/:id/undelegateResources/build
Adds typed Express route (PostUndelegateResources) and handleV2UndelegateResources handler
Delegation and undelegation share private helpers (buildResourceManagements, sendResourceManagement, sendResourceManagements) to eliminate code duplication

stakingParams relay

Adds stakingParams?: unknown to PrebuildTransactionResult so staking metadata flows from the build response through to submitTransaction, enabling the indexer to identify resource management transfers correctly

Test plan

Unit test: buildResourceDelegations / buildResourceUndelegations call the right endpoints and post-process prebuilds
Unit test: sendResourceDelegation / sendResourceUndelegation route correctly per wallet type
Express: POST /api/v2/ttrx/wallet/:id/delegateResources returns 200/202/400 as appropriate
Express: POST /api/v2/ttrx/wallet/:id/undelegateResources returns 200/202/400 as appropriate

Linear: CHALO-287

linear · 2026-04-20T09:06:14Z

CHALO-287 Bulk TRX Resource Delegation API

bhavidhingra · 2026-04-20T10:34:31Z

@claude review

pranavjain97 · 2026-04-22T15:31:42Z

Flush, please request re-review when ready for review.

pranavjain97

TSS detection uses coin-level check instead of wallet-level, receiverAddress never populated, and no tests included

pranavjain97 · 2026-04-27T20:49:59Z

+    const params = coin.supportsTss() ? createTSSSendParams(req, wallet) : createSendParams(req);
+    result =
+      type === 'delegateResource'
+        ? await wallet.sendResourceDelegations(params)


existing handlers check wallet._wallet.multisigType === 'tss', not coin.supportsTss(). these can diverge, should use the wallet-level check

pranavjain97 · 2026-04-27T20:50:03Z

+    // Surface unexpected errors as 400 rather than 500
+    (err as any).status = 400;
+    throw err;
+  }


all other handlers assign err.status = 400 directly without a cast. use the same pattern

pranavjain97 · 2026-04-27T20:50:04Z

+  message: t.string,
+  /** Receiver address that failed, if available */
+  receiverAddress: t.union([t.string, t.undefined]),
+});


t.union([t.string, t.undefined]) doesn't decode an absent JSON key correctly, use optional(t.string) consistent with the other fields

pranavjain97 · 2026-04-27T20:50:06Z

+   */
+  async buildResourceDelegations(
+    params: BuildResourceDelegationTransactionOptions
+  ): Promise<PrebuildTransactionResult[]> {


receiverAddress is typed as available but never populated here. either populate it from unsignedBuild or remove the field from the types

pranavjain97 · 2026-04-27T20:50:09Z

+
+    if (!Array.isArray(buildResponse.transactions)) {
+      throw new Error(`Unexpected response from ${endpoint}: missing transactions array`);
+    }


build errors are swallowed at debug level. if some entries failed to build, those failures won't appear in the final { success, failure } response. should these be surfaced?

pranavjain97 · 2026-04-27T20:50:11Z

+  sendResourceDelegations(params: BuildResourceDelegationTransactionOptions): Promise<{
+    success: any[];
+    failure: { message: string; receiverAddress?: string }[];
+  }>;


sendResourceDelegation and sendResourceUndelegation return Promise<any>, define a typed result interface

defined ResourceManagementSendResult

pranavjain97 · 2026-04-27T20:50:14Z

@@ -1096,6 +1117,18 @@ export interface IWallet {
  buildAccountConsolidations(params?: BuildConsolidationTransactionOptions): Promise<PrebuildTransactionResult[]>;


is resource delegation going to be used by other coins, or is this TRX-specific? if it's only TRX, every other coin gets 6 dead methods. consider keeping these on the coin class or as standalone helpers instead of bloating the wallet interface

keeping it as is - it follows the identical pattern of buildAccountConsolidations/sendAccountConsolidation with a supportsResourceDelegation() guard

Adds buildAccountDelegations, sendAccountDelegation, sendAccountDelegations to the Wallet class and IWallet interface, mirroring the consolidation API. Adds Express typed route schema and handler for POST /api/v2/:coin/wallet/:id/delegateResources with TSS/custodial/hot wallet branching and partial-success (202) response handling. CHALO-287 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

bhavidhingra requested review from a team as code owners April 20, 2026 09:06

bhavidhingra requested review from Marzooqa and pranavjain97 April 20, 2026 09:06

bhavidhingra force-pushed the chalo-287-bulk-trx-resource-delegation-sdk branch from 496a288 to 5bc64a4 Compare April 20, 2026 10:01

bhavidhingra force-pushed the chalo-287-bulk-trx-resource-delegation-sdk branch from 5bc64a4 to 42b5824 Compare April 20, 2026 10:52

bhavidhingra marked this pull request as draft April 20, 2026 10:54

bhavidhingra force-pushed the chalo-287-bulk-trx-resource-delegation-sdk branch 6 times, most recently from 15b4e19 to 5019af4 Compare April 22, 2026 15:09

bhavidhingra force-pushed the chalo-287-bulk-trx-resource-delegation-sdk branch 3 times, most recently from 982359a to b22a03a Compare April 23, 2026 13:28

bhavidhingra marked this pull request as ready for review April 25, 2026 12:20

pranavjain97 requested changes Apr 27, 2026

View reviewed changes

bhavidhingra force-pushed the chalo-287-bulk-trx-resource-delegation-sdk branch from b22a03a to aaf7a36 Compare April 28, 2026 07:20

		@@ -1096,6 +1117,18 @@ export interface IWallet {
		buildAccountConsolidations(params?: BuildConsolidationTransactionOptions): Promise<PrebuildTransactionResult[]>;

Conversation

bhavidhingra commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Resource Delegation

Resource Undelegation

stakingParams relay

Test plan

Uh oh!

linear Bot commented Apr 20, 2026

Uh oh!

bhavidhingra commented Apr 20, 2026

Uh oh!

pranavjain97 commented Apr 22, 2026

Uh oh!

pranavjain97 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bhavidhingra commented Apr 20, 2026 •

edited

Loading