Conversation
Codecov Report❌ Patch coverage is
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
I tried running a query through the ARAX pathfinder and it's unclear what happened. I got these logs: but nothing else before it was timed out after 5 minutes. I sent it Imatinib->Asthma. |
|
Hi @maximusunc, I changed the parameters to make it faster for now. I will get back to Shepherd-pathfinder and check it probably next week to figure out what the problem is. |
maximusunc
left a comment
There was a problem hiding this comment.
When testing with Imatinib->Asthma, your Pathfinder is returning 0 paths. Is this intended?
workers/arax_pathfinder/worker.py
Outdated
| try: | ||
| start = time.perf_counter() | ||
| logger.info("Starting pathfinder.get_paths()") | ||
| result, aux_graphs, knowledge_graph = pathfinder.get_paths( |
There was a problem hiding this comment.
I'm not sure if your pathfinder code is asynchronous or not, but this call is blocking and so your pathfinder implementation can only handle one query at a time. Is this intended?
There was a problem hiding this comment.
Hi @maximusunc
Could you please provide me your json query that you sent and got 0 paths?
There was a problem hiding this comment.
Here is my query and I got result for this one.
{
"message": {
"query_graph": {
"nodes": {
"n0": {
"ids": [
"CHEBI:31690"
]
},
"n1": {
"ids": [
"MONDO:0004979"
]
}
},
"paths": {
"p0": {
"subject": "n0",
"object": "n1",
"predicates": [
"biolink:related_to"
],
"constraints": []
}
}
}
}
}
There was a problem hiding this comment.
It is now can handle multiple queries.
|
I ran some tests last night and ran into some issues. I was able to run your query and get back results, but then I tried sending 5 concurrent queries and while they all fired off, I got this error for all of them: And then I tried backing off and just sending one query and got this error: Now this doesn't seem to be an issue with Shepherd but more coming from these external services. So my follow up questions are: |
|
PloverDB Concurrency: The error came from PloverDB, which is actually designed to handle thousands of requests in parallel for Pathfinder and other services. The KG2 team is currently working hard on its stability. Pathfinder Performance: Pathfinder is both CPU-bound and IO-bound. It already uses multiprocessing in its core code to calculate rankings and expand nodes while building paths and trees. The subsequent failure for the single query shows that the database connection to arax-databases-mysql was also down. I will ping KG2 team for this one. Thanks Max |
Hi @maximusunc,
Please review this pull request.