Fix coverage handling for stuck scenario warning#444
Merged
dfremont merged 1 commit intoBerkeleyLearnVerify:mainfrom Mar 17, 2026
Merged
Fix coverage handling for stuck scenario warning#444dfremont merged 1 commit intoBerkeleyLearnVerify:mainfrom
dfremont merged 1 commit intoBerkeleyLearnVerify:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
+ Coverage 89.66% 89.69% +0.03%
==========================================
Files 48 48
Lines 13193 13194 +1
==========================================
+ Hits 11829 11834 +5
+ Misses 1364 1360 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a coverage-only failure in
test_scenario_stuck.The new stuck-scenario test passes in a normal test run, but fails under the coverage workflow because
src/scenic/core/dynamics/scenarios.pysuppresses the warning wheneversys.gettrace()is set. Underpytest --cov, tracing is enabled, so the warning is skipped and the test fails.behaviors.pyalready has logic to allow the warning under coverage while still suppressing it for a real debugger. This PR makesscenarios.pyconsistent with that behavior.Issue Link
N/A
Checklist
pytestand/or other meansAdditional Notes
N/A