chore(webrtc-example): refresh lockfile and clear Next 16 audit findings - #22
Open
Nisarg48 wants to merge 3 commits into
Open
chore(webrtc-example): refresh lockfile and clear Next 16 audit findings#22Nisarg48 wants to merge 3 commits into
Nisarg48 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (5)
examples/webrtc-client-example/README.md:7
- Spelling/grammar issue in the overview sentence: "icludes" should be "includes", and "which aims" should agree with the plural "applications".
Squawk is a realtime broadcast service from Benzinga which includes important headlines, price movement, and rumors as stories develop to give traders and investors news in the fastest and most convenient form. This repo icludes sample applications, which aims to elaborate how you can connect to Squawk.
examples/webrtc-client-example/README.md:20
- There are extra spaces inside the parentheses around "Chrome recommended".
- Access the demo page from your browser ( Chrome recommended )
examples/webrtc-client-example/README.md:13
- Extra space before the question mark in the heading makes the Markdown look unpolished.
### How to run the demo ?
examples/webrtc-client-example/package.json:31
- The resolved Next.js version in the refreshed lockfile requires Node >= 20.9.0. Adding an explicit Node engine constraint helps developers avoid confusing install/runtime failures when using older Node versions.
},
"dependencies": {
"@benzinga/benzinga-squawk-sdk": "^0.9.0",
"next": "^16.2.5",
"react": "^18.2.0",
examples/webrtc-client-example/README.md:15
- The first bullet under "How to run" is missing terminal punctuation, which reads like an incomplete sentence.
- You need a valid Session, API Key, or JWT in order to run the demo. Please visit [the core API doc](https://docs.benzinga.io/benzinga/squawk-v4.html#Authenticate) on how to get a valid key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
next@^16.2.5→ resolves tonext@16.3.0)overrides; refreshedpackage-lock.jsonso patched transitive versions resolve naturallynpm auditreports 0 vulnerabilities after clean installtsconfig.json(target: ES2017, moduleResolution: bundler)Notable package updates (resolved versions)
next16.3.0axios1.19.0(via@benzinga/benzinga-squawk-sdk)follow-redirects1.16.0(via axios)postcss8.5.23(via next)js-yaml4.3.1(eslint path); older3.15.1still present under Jest/babelpicomatch4.0.5and2.3.2both present (Jest/micromatch vs newer tooling)@eslint/eslintrc3.3.6@typescript-eslint/*8.66.0Direct dependency ranges in
package.jsonare mostly unchanged; this PR mainly refreshes the lockfile and removes overrides that were previously used for Vanta/audit remediation.Why overrides were removed
Parent packages/ranges now resolve to patched transitive versions without forcing overrides. Overrides can be re-added later only if Vanta/
npm auditflags a transitive that the parent cannot upgrade yet.