Skip to content

chore(webrtc-example): refresh lockfile and clear Next 16 audit findings - #22

Open
Nisarg48 wants to merge 3 commits into
masterfrom
fix-package-vulnerabilities
Open

chore(webrtc-example): refresh lockfile and clear Next 16 audit findings#22
Nisarg48 wants to merge 3 commits into
masterfrom
fix-package-vulnerabilities

Conversation

@Nisarg48

@Nisarg48 Nisarg48 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update WebRTC example dependency lockfile for Next.js 16 (next@^16.2.5 → resolves to next@16.3.0)
  • Remove npm overrides; refreshed package-lock.json so patched transitive versions resolve naturally
  • npm audit reports 0 vulnerabilities after clean install
  • Modernize tsconfig.json (target: ES2017, moduleResolution: bundler)

Notable package updates (resolved versions)

Package Notes
next 16.3.0
axios 1.19.0 (via @benzinga/benzinga-squawk-sdk)
follow-redirects 1.16.0 (via axios)
postcss 8.5.23 (via next)
js-yaml 4.3.1 (eslint path); older 3.15.1 still present under Jest/babel
picomatch 4.0.5 and 2.3.2 both present (Jest/micromatch vs newer tooling)
@eslint/eslintrc 3.3.6
@typescript-eslint/* resolves to 8.66.0

Direct dependency ranges in package.json are mostly unchanged; this PR mainly refreshes the lockfile and removes overrides that were previously used for Vanta/audit remediation.

Why overrides were removed

Parent packages/ranges now resolve to patched transitive versions without forcing overrides. Overrides can be re-added later only if Vanta/npm audit flags a transitive that the parent cannot upgrade yet.

This comment was marked as resolved.

This comment was marked as resolved.

@Nisarg48
Nisarg48 requested a lite review from Copilot August 5, 2026 12:01
@Nisarg48 Nisarg48 changed the title chore(webrtc-example): update deps and tsconfig for Next 16 chore(webrtc-example): refresh lockfile and clear Next 16 audit findings Aug 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (5)

examples/webrtc-client-example/README.md:7

  • Spelling/grammar issue in the overview sentence: "icludes" should be "includes", and "which aims" should agree with the plural "applications".
Squawk is a realtime broadcast service from Benzinga which includes important headlines, price movement, and rumors as stories develop to give traders and investors news in the fastest and most convenient form. This repo icludes sample applications, which aims to elaborate how you can connect to Squawk.

examples/webrtc-client-example/README.md:20

  • There are extra spaces inside the parentheses around "Chrome recommended".
- Access the demo page from your browser ( Chrome recommended )

examples/webrtc-client-example/README.md:13

  • Extra space before the question mark in the heading makes the Markdown look unpolished.
### How to run the demo ?

examples/webrtc-client-example/package.json:31

  • The resolved Next.js version in the refreshed lockfile requires Node >= 20.9.0. Adding an explicit Node engine constraint helps developers avoid confusing install/runtime failures when using older Node versions.
  },
  "dependencies": {
    "@benzinga/benzinga-squawk-sdk": "^0.9.0",
    "next": "^16.2.5",
    "react": "^18.2.0",

examples/webrtc-client-example/README.md:15

  • The first bullet under "How to run" is missing terminal punctuation, which reads like an incomplete sentence.
- You need a valid Session, API Key, or JWT in order to run the demo. Please visit [the core API doc](https://docs.benzinga.io/benzinga/squawk-v4.html#Authenticate) on how to get a valid key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants