Exempt administrators from per-IP login delay - #3442
Open
computertech1012 wants to merge 1 commit into
Open
Conversation
Contributor
|
@computertech1012 Thanks this is how it should behave |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This change makes administrator accounts bypass the server's per-IP login delay, matching the existing administrator exemption from the maximum-logins-per-IP limit.
The delay still applies to ordinary accounts. Invalid credentials and banned accounts are unchanged because the exemption is evaluated only after successful authentication. The administrator check is also evaluated before
LoginsExceeded(), so administrator logins do not create or refresh the per-IP delay timestamp.This helps trusted server-management, radio, and bot accounts recover when several legitimate clients share one public IP address, without weakening the delay for guests or ordinary users.
Tests performed on a clean Linux checkout:
testAdminLoginDelayExemptionfive times against the patched Standard server.testLoginDelaytest to verify ordinary accounts remain protected.@bear101, this is the narrower administrator-only approach discussed in #3440.
Thanks for reading!