Skip to content

Exempt administrators from per-IP login delay - #3442

Open
computertech1012 wants to merge 1 commit into
BearWare:masterfrom
computertech1012:feature/admin-login-delay-bypass
Open

Exempt administrators from per-IP login delay#3442
computertech1012 wants to merge 1 commit into
BearWare:masterfrom
computertech1012:feature/admin-login-delay-bypass

Conversation

@computertech1012

Copy link
Copy Markdown
Contributor

Hi,

This change makes administrator accounts bypass the server's per-IP login delay, matching the existing administrator exemption from the maximum-logins-per-IP limit.

The delay still applies to ordinary accounts. Invalid credentials and banned accounts are unchanged because the exemption is evaluated only after successful authentication. The administrator check is also evaluated before LoginsExceeded(), so administrator logins do not create or refresh the per-IP delay timestamp.

This helps trusted server-management, radio, and bot accounts recover when several legitimate clients share one public IP address, without weakening the delay for guests or ordinary users.

Tests performed on a clean Linux checkout:

  • Built the Standard and Professional server binaries, JNI libraries, and Java test artifacts.
  • Ran testAdminLoginDelayExemption five times against the patched Standard server.
  • Interleaved all five runs with the existing testLoginDelay test to verify ordinary accounts remain protected.
  • Repeated the same five-plus-five focused matrix with the Professional JNI client against the patched server.
  • All 20 focused test runs passed.

@bear101, this is the narrower administrator-only approach discussed in #3440.

Thanks for reading!

@amirmahdifard

Copy link
Copy Markdown
Contributor

@computertech1012 Thanks this is how it should behave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants