Skip to content

Fix action bar in text messages activity and add copy all and clear - #3379

Open
amirmahdifard wants to merge 1 commit into
BearWare:masterfrom
amirmahdifard:textmessageDLGRework
Open

Fix action bar in text messages activity and add copy all and clear#3379
amirmahdifard wants to merge 1 commit into
BearWare:masterfrom
amirmahdifard:textmessageDLGRework

Conversation

@amirmahdifard

@amirmahdifard amirmahdifard commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Fixed the action bar in text message activity And correctly Added the globel actions.
this fixes #3413

@AbolfazlSaeidifar

Copy link
Copy Markdown
Contributor

@schulle4u
@poretsky
@claude
@amirmahdifard
As one of the TeamTalk translators and a long-time user, I really believe this feature is important for keeping the Windows and Android clients consistent.
I was actually the one who suggested this feature to Amir and asked him to open the pull request for it.
There are many times when we need to back up our private message history with different people. Since most TeamTalk users are blind, copying messages one by one is extremely slow and tedious with screen reader. With this feature, we'd be able to copy an entire conversation history with a single tap, which would save a lot of time and effort.
Since this functionality already exists in the Windows client, I'd really appreciate it if you could make reviewing and merging this pull request a high priority so it can be included in the next update.
I also know quite a few other users who have asked for this feature on Android in the past, so I don't think I'm the only one who would benefit from it. Thank you for considering it.

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@hwangsihu was merging my pull requests before, I don't know why he is no longer viewing them. Again my pull requests are being long standing.
btw, @AbolfazlSaeidifar Thanks for your valuable opinion to me. This feature is acseptable feature, We just need someone to merge my pull requests a bit more activly. Then you will have it in tt 5.23 update.
As I said so many times before, I'm happy to work for teamtalk, Just my request is that my pull requests should be merged a little bit quicker.

@The-fake-psychologist

Copy link
Copy Markdown

Hello. Adding a "Copy All" option to the Android client would be a really useful improvement. It would be helpful for some if you could merge this pull request. It would also help bring the Android client closer to feature parity with the Windows client. It would make backing up conversations much easier for many users, especially those of us who rely on TeamTalk every day. Thanks in advance.

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

wow. I didn't know that this feature had a lot of followers. I was planning to implement it at some point anyway, But If I knu that people like copy all in android this much, I would implement it much ulier😊

@computertech1012

Copy link
Copy Markdown
Contributor

Hi,
To answer your question @amirmahdifard I don't know. But I do know that this @hwangsihu has became contributor and has more abilities than you do which I do not think is right, because you are the one who is writing Android client. I don't think it's fair or correct.
Anyways, really thank you for adding this feature. This will also save a lot of time.
I also want to take time to thank you for your contributions to the client. And thank you for spending your time with it.
I know that Flutter client is coming, and I am really excited about that too, but it really is good to see you are working to continue to work on the clients.
Thanks for reading!

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@computertech1012 hi.
About flutter client, I onnistly will not use it and I will take responceability and maintane the current android client always, because all my iranian friends told me to keep contribute to current teamtalk android because they like this client and all features that I have added to it and how it is clean now.
About @hwangsihu I know that he has contributing rights. In this project, some people I know are havving contributor rights, that didn't add more than 10 line of code, and are not active at all.
I'm just working, opening pull requests, in hope of someone will finally press the merge button. Never Anyone didn't say thank you to me for all my activity. But people annoyed me a lot.
But god knows everything I did, so may be god will do something about it.

@bear101

bear101 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Is there an issue or discussion linked to this issue? If no one has requested this feature then there's no need to add additional complexity.

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@bear101 it's like my all features and bug fixes to teamtalk android. Is it so hard for you to press to merge button? even in the comments of this pr and all my other prs you can see how people need some features. I'm always working to add the things that are missing on teamtalk android. Please start merging my prs.

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@AbolfazlSaeidifar see, You asked me in telegram to do this pr so many times and finally I did, and now see, @bear101 is annoying, he is disagreeing and not merging my prs for no reason. All my work for teamtalk is waysted because of this person.
@hwangsihu If I remove the changelog modification, will you be able to merge this pr? or I should delete it and waste my work? now I wunder what all those people will say.

@AbolfazlSaeidifar

Copy link
Copy Markdown
Contributor

@bear101 Please be reasonable. Isn’t the goal to bring the features available on the Windows client over to the Android client as well? I was the one who requested this feature in the first place.
You’re not blind, so you may not realize how difficult it can be for a blind user to copy all of their messages using a screen reader. What exactly would you lose by having this feature available on the Android client? Why not add it?

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@AbolfazlSaeidifar he likes to find a reason to refuse to merge my prs. Heh. Teamtalk is a dead project for a long time, I was the one who kept the android client a live and corentin kept the desktop client a live since a long time. If we stop, lets see who will code for teamtalk's next updates🤣

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@bear101 You never saw what I did. For a long time I'm working on your project because I know people needed these features. From teamtalk 5.16 until now, I constantly worked on the android client and improved it so much like this, But you never understand what is people's value. You were always disrespect, always bad to anyone working here. You don't understand that atitude is the first sign of a good project. Now there is no one to work on this project because you have annoyed everyone who wanted to contribute here.

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@bear101 hi
I didn't open this pr for no reason. So many people have requested this as well as with the others and I did.
Please merge it. Thanks a lot

@computertech1012

Copy link
Copy Markdown
Contributor

Hi,
Hello @amirmahdifard thank you for adding this to the client. I really do think that this will be useful.
Thanks for reading!

@bear101

bear101 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@amirmahdifard you write "So many people have requested this". Please link the discussion/issue so we're able to see why.

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@bear101 sadly, every request doesn't have open issue on github for it.
First, you can see the comments here. Because everyone in the persian comunity knows that I work on teamtalk android, they always request new features and bug fixes from me in my teamtalk server or telegram, And I work on their requests.
It was like that All these months and years that I was working on teamtalk android.
About this feature. When the internet was disconnected in iran, persian people was always used iranian teamtalk servers, and they really needed some features, like copying messages. Because they needed to send proxy link, v2ray config links to each other in teamtalk, and they needed to copy these to be able to paste in their telegram proxys or vpn configuration
And, @AbolfazlSaeidifar requested this feature in telegram and he said that he always keeps backup of his chats in teamtalk. He said in windows this feature exist and he can copy all of his messages with the copy all option in the context menu, but in android, he is havving a hard time copying his messages with talkback one by one, and paste in to a notepad txt file or send somewhere.
This feature is requested from me with all reasons and it exist on windows, so I implemented it like all other features I have implemented, I tested it on my phone, I'm just asking you to merge it.
Corentin was also like this. When people requested him features from anywhere, he opened pr and implemented.
Please merge it. Thank you!

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@bear101 please, merge this. Now everyone started messaging me they are asking and complaning that why this is not yet inclooded in the beta

@AbolfazlSaeidifar

Copy link
Copy Markdown
Contributor

@bear101 #3413

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

I've linked this pr to that issue. Thanks.

@amirmahdifard

Copy link
Copy Markdown
Contributor Author

@bear101 I see that you have updated the version again. Please merge my prs before you release the new beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Copy All option is missing from the private message history in the TeamTalk Android client

5 participants