docs: update manual installation - #384
Open
yoyocircle wants to merge 2 commits into
Open
Conversation
Signed-off-by: yoyocircle <61043261+yoyocircle@users.noreply.github.com>
1. adjust the wrong paths 2. add description about configuring KMS v2 3. Mounting the encryption configuration is also required Signed-off-by: yoyocircle <61043261+yoyocircle@users.noreply.github.com>
yoyocircle
requested review from
Anish Ramasekar (aramase),
Mo Khan (enj) and
Nilekh Chaudhari (nilekhc)
as code owners
May 14, 2024 10:10
Author
@microsoft-github-policy-service agree |
| ### 4. Create encryption configuration | ||
|
|
||
| Create a new encryption configuration file `/etc/kubernetes/manifests/encryptionconfig.yaml` using the appropriate properties for the `kms` provider: | ||
| Create a new encryption configuration file `/etc/kubernetes/enc/encryptionconfig.yaml` using the appropriate properties for the `kms` provider: |
There was a problem hiding this comment.
These bits look important to get right, I imagine incorrect paths will result in a broken install. I'm not familiar off the top of my head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Related to #239
Notes for Reviewers:
some of contents are referred to official documents of setting up the encryption configuration.