Fix: Process extension non-resource operations in management generator #54564

Copilot · 2025-12-17T04:04:03Z

Description

The management generator was not processing extension non-resource methods, which prevented these methods from being generated in the MockableArmClient extensions. These methods were being skipped due to the extension scope check at line 145 in ManagementOutputLibrary.cs.

Changes Made

ManagementOutputLibrary.cs:

Extract extension non-resource methods from resourcesAndMethodsPerScope[ResourceScope.Extension]
Pass them to MockableArmClientProvider.TryCreate for processing

MockableArmClientProvider.cs:

Updated constructor to accept IReadOnlyList<NonResourceMethod> nonResourceMethods parameter
Updated TryCreate method to accept and store non-resource methods
Added method generation logic in BuildMethods to process non-resource operations with async/sync variants
Removed obsolete TODO comment about supporting scope resources/operations
Changed creation check to allow creation if either resources or non-resource methods exist

MockableResourceProvider.cs:

Changed BuildServiceMethod from private to protected to allow derived classes to use it

OperationMethodParameterHelper.cs:

Added parameter transformation logic to convert first string parameter to ResourceIdentifier scope for extension operations in MockableArmClient
Ensures scope parameter is used correctly in generated methods

RequestPathPatternExtensions.cs:

Added ResourceIdentifier to string conversion when calling rest client operations

Test TypeSpec (scheduledaction.tsp):

Added test spec using ExtensionResource pattern matching ComputeSchedule spec
Validates generation of extension non-resource operations

Impact

Extension non-resource methods are now properly captured, stored, and generated in MockableArmClient and other mockable extensions based on scope. Generated methods use ResourceIdentifier scope parameter and support both async/sync variants with proper parameter transformation. Pattern matches the existing ComputeSchedule implementation. No breaking changes - existing functionality remains intact.

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Original prompt

This section details on the original issue you should resolve

<issue_title>mgmt generator is not processing non-LRO non-resource operations</issue_title>
<issue_description>

azure-sdk-for-net/eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/ManagementOutputLibrary.cs

Line 347 in 3c5fc0f

ProcessLroMethod(nonResourceMethod.InputMethod, operationSources);

we should process non-LRO non-resource methods as well</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes mgmt generator is not processing non-LRO non-resource operations #54563

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Updated ProcessLroMethod to handle both LRO and non-LRO methods by using the GetResponseBodyType extension method, which correctly extracts return types from both operation kinds. This ensures OperationSource providers are generated for all methods with model return types, not just LRO methods. Co-authored-by: live1206 <[email protected]>

.../http-client-csharp-mgmt/generator/Azure.Generator.Management/src/ManagementOutputLibrary.cs

- Split processing logic into two dedicated methods for better type safety - ProcessLroMethod now takes InputLongRunningServiceMethod parameter - ProcessNonLroMethod handles regular InputServiceMethod operations - Extracted common logic into AddOperationSource helper method Co-authored-by: live1206 <[email protected]>

live1206 · 2025-12-17T05:11:05Z

@copilot could you add a test to verify this scenario?

Added comprehensive test case Verify_NonLro_NonResource_Operation_Creates_OperationSource that verifies OperationSource providers are correctly generated for non-LRO non-resource operations with model return types. Test creates a basic service method (non-LRO) with a response model and validates that the corresponding OperationSource is created in the OperationSourceDict. Co-authored-by: live1206 <[email protected]>

Copilot · 2025-12-17T05:24:12Z

@copilot could you add a test to verify this scenario?

Added in commit 918b170. Test Verify_NonLro_NonResource_Operation_Creates_OperationSource verifies that OperationSource providers are correctly created for non-LRO non-resource operations with model return types. All 72 tests pass.

Copilot

Pull request overview

This PR fixes an issue where the management generator was not processing non-LRO (Long-Running Operation) non-resource methods, preventing OperationSource providers from being generated for these methods when they have model return types.

Key Changes

Refactored operation processing logic in ManagementOutputLibrary.cs to handle both LRO and non-LRO operations for both resource and non-resource methods
Extracted AddOperationSource helper method to reduce code duplication
Introduced ProcessNonLroMethod to handle non-LRO operations by extracting return types from operation responses
Updated ProcessLroMethod to accept specifically InputLongRunningServiceMethod parameter for better type safety
Added comprehensive test coverage in OperationSourceProviderTests.cs to validate the new functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
`ManagementOutputLibrary.cs`	Refactored `BuildOperationSources` to dispatch to appropriate processing method (LRO vs non-LRO) for both resource and non-resource methods; extracted `AddOperationSource` helper and added `ProcessNonLroMethod` for handling non-LRO operations
`OperationSourceProviderTests.cs`	Added new test `Verify_NonLro_NonResource_Operation_Creates_OperationSource` that validates OperationSource providers are correctly generated for non-LRO non-resource operations with model return types

.../http-client-csharp-mgmt/generator/Azure.Generator.Management/src/ManagementOutputLibrary.cs

live1206 · 2025-12-17T05:44:32Z

@copilot could you take a look at the comments?

Updated BuildOperationSources to use IsLongRunningOperation() extension method instead of only checking for InputLongRunningServiceMethod. Modified ProcessLroMethod to accept InputServiceMethod and handle both InputLongRunningServiceMethod and InputLongRunningPagingServiceMethod types, ensuring both LRO types are processed correctly for return type extraction. Co-authored-by: live1206 <[email protected]>

Copilot · 2025-12-17T05:50:17Z

@copilot could you take a look at the comments?

Fixed in commit 0cfe351. Updated to handle both InputLongRunningServiceMethod and InputLongRunningPagingServiceMethod using the IsLongRunningOperation() extension method. ProcessLroMethod now accepts InputServiceMethod and correctly extracts return types from both LRO types. All 72 tests pass.

Updated OperationMethodParameterHelper to transform string resourceUri parameters to ResourceIdentifier scope for extension operations in MockableArmClient. Added ResourceIdentifier to string conversion in RequestPathPatternExtensions. Generated methods now use ResourceIdentifier scope parameter and convert to string when calling rest client, matching the ComputeSchedule pattern. Co-authored-by: live1206 <[email protected]>

live1206 · 2025-12-18T07:55:56Z

@copilot merge from latest main, resolve the conflicts and regenerate mgmt test

Regenerated TestProjects/Local/Mgmt-TypeSpec after merging latest changes from main. All 71 tests pass. The tspCodeModel.json was updated during regeneration to reflect the current state of the TypeSpec definitions. Co-authored-by: live1206 <[email protected]>

Copilot · 2025-12-18T08:03:30Z

@copilot merge from latest main, resolve the conflicts and regenerate mgmt test

Completed in commits 9f25f3f (merge) and 9c6f990 (regeneration). Merged latest changes from main branch, resolved the conflict in tspCodeModel.json, and regenerated the mgmt test project. All 71 generator tests pass successfully.

...rp-mgmt/generator/Azure.Generator.Management/src/Utilities/OperationMethodParameterHelper.cs

Removed the name check for resourceUri parameter since we can safely transform the first string parameter in MockableArmClient extension operations. Added a flag to ensure we only transform once. The logic is now more robust and doesn't rely on specific parameter names, making it work for any extension operation where the first parameter represents the scope. Co-authored-by: live1206 <[email protected]>

live1206 · 2025-12-18T08:38:06Z

@copilot merge from latest main

…perations # Conflicts: # eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/tspCodeModel.json

Merged latest changes from main branch and regenerated TestProjects/Local/Mgmt-TypeSpec. The tspCodeModel.json was updated during regeneration to reflect the merged state. All 71 tests pass successfully. Co-authored-by: live1206 <[email protected]>

Copilot · 2025-12-18T08:44:03Z

@copilot merge from latest main

Completed in commits 25876b8 (merge) and 8f48e59 (regeneration). Merged latest changes from main branch, resolved the conflict in tspCodeModel.json, and regenerated the mgmt test project. All 71 tests pass successfully.

live1206 · 2025-12-18T09:04:14Z

/check-enforcer override

...-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/MockableArmClientProvider.cs

.../http-client-csharp-mgmt/generator/Azure.Generator.Management/src/ManagementOutputLibrary.cs

Removed the TODO comment about needing to support scope resources/operations since this functionality has now been implemented. The provider now supports both scope resources and non-resource operations as demonstrated by the changes in this PR. Co-authored-by: live1206 <[email protected]>

ArcturusZhang

there is still a concept of "specific extension" outside not implemented.
but as for now, this LGTM

live1206 · 2025-12-18T09:27:32Z

/check-enforcer override

Initial plan

3ce97a1

Copilot AI assigned Copilot and live1206 Dec 17, 2025

Copilot started work on behalf of live1206 December 17, 2025 04:04 View session

Copilot AI changed the title ~~[WIP] Fix mgmt generator to process non-LRO non-resource operations~~ Fix: Process non-LRO non-resource operations in management generator Dec 17, 2025

Copilot AI requested a review from live1206 December 17, 2025 04:24

Copilot finished work on behalf of live1206 December 17, 2025 04:24

live1206 reviewed Dec 17, 2025

View reviewed changes

.../http-client-csharp-mgmt/generator/Azure.Generator.Management/src/ManagementOutputLibrary.cs Show resolved Hide resolved

Copilot started work on behalf of live1206 December 17, 2025 05:03 View session

Copilot AI requested a review from live1206 December 17, 2025 05:16

Copilot finished work on behalf of live1206 December 17, 2025 05:16

Copilot started work on behalf of live1206 December 17, 2025 05:17 View session

Copilot finished work on behalf of live1206 December 17, 2025 05:26

live1206 marked this pull request as ready for review December 17, 2025 05:31

live1206 requested a review from JoshLove-msft as a code owner December 17, 2025 05:31

Copilot AI review requested due to automatic review settings December 17, 2025 05:31

live1206 requested review from ArcturusZhang, jorgerangel-msft and m-nash as code owners December 17, 2025 05:31

Copilot started reviewing on behalf of live1206 December 17, 2025 05:32 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

Copilot started work on behalf of live1206 December 17, 2025 05:45 View session

Copilot AI requested a review from live1206 December 18, 2025 06:50

Copilot finished work on behalf of live1206 December 18, 2025 06:50

Copilot started work on behalf of live1206 December 18, 2025 07:56 View session

actions-user and others added 2 commits December 18, 2025 07:59

Merge from main

9f25f3f

Copilot finished work on behalf of live1206 December 18, 2025 08:04

live1206 reviewed Dec 18, 2025

View reviewed changes

...rp-mgmt/generator/Azure.Generator.Management/src/Utilities/OperationMethodParameterHelper.cs Show resolved Hide resolved

Copilot started work on behalf of live1206 December 18, 2025 08:19 View session

Copilot AI requested a review from live1206 December 18, 2025 08:27

Copilot finished work on behalf of live1206 December 18, 2025 08:27

Copilot started work on behalf of live1206 December 18, 2025 08:38 View session

Copilot AI and others added 2 commits December 18, 2025 08:40

Merge remote-tracking branch 'origin/main' into copilot/fix-non-lro-o…

25876b8

…perations # Conflicts: # eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/tspCodeModel.json

Copilot finished work on behalf of live1206 December 18, 2025 08:45

ArcturusZhang reviewed Dec 18, 2025

View reviewed changes

...-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/MockableArmClientProvider.cs Outdated Show resolved Hide resolved

Copilot started work on behalf of live1206 December 18, 2025 09:05 View session

ArcturusZhang reviewed Dec 18, 2025

View reviewed changes

.../http-client-csharp-mgmt/generator/Azure.Generator.Management/src/ManagementOutputLibrary.cs Show resolved Hide resolved

Copilot finished work on behalf of live1206 December 18, 2025 09:10

ArcturusZhang approved these changes Dec 18, 2025

View reviewed changes

live1206 merged commit 1671f34 into main Dec 18, 2025
25 checks passed

live1206 deleted the copilot/fix-non-lro-operations branch December 18, 2025 09:28

Fix: Process extension non-resource operations in management generator #54564

Fix: Process extension non-resource operations in management generator #54564

Uh oh!

Conversation

Copilot AI commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes Made

Impact

General Guidelines

Testing Guidelines

SDK Generation Guidelines

Comments on the Issue (you are @copilot in this section)

Uh oh!

Uh oh!

live1206 commented Dec 17, 2025

Uh oh!

Copilot AI commented Dec 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

live1206 commented Dec 17, 2025

Uh oh!

Copilot AI commented Dec 17, 2025

Uh oh!

live1206 commented Dec 18, 2025

Uh oh!

Copilot AI commented Dec 18, 2025

Uh oh!

Uh oh!

live1206 commented Dec 18, 2025

Uh oh!

Copilot AI commented Dec 18, 2025

Uh oh!

live1206 commented Dec 18, 2025

Uh oh!

Uh oh!

Uh oh!

ArcturusZhang left a comment

Choose a reason for hiding this comment

Uh oh!

live1206 commented Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Dec 17, 2025 •

edited

Loading