[FrontDoor] Add Sensitivity for WafManagedRuleOverrideObject #28983
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This PR adds a new optional Sensitivity parameter to the New-AzFrontDoorWafManagedRuleOverrideObject cmdlet as part of the FrontDoor module version 2.0.0 release. The parameter allows users to specify sensitivity levels (Low, Medium, High) when creating managed rule override objects for WAF policies. This change aligns with the module's migration to AutoRest PowerShell V4 and the swagger version bump to 2025-10-01.
Key changes:
- Added
-Sensitivityparameter with PSArgumentCompleter for values "Low", "Medium", "High" to the cmdlet - Updated help documentation for both the Autorest and main module locations
- Version bumped to 2.0.0 as part of the larger module update
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/FrontDoor/FrontDoor.Autorest/custom/New-AzFrontDoorWafManagedRuleOverrideObject.ps1 | Added Sensitivity parameter with argument completer and conditional assignment logic |
| src/FrontDoor/FrontDoor.Autorest/docs/New-AzFrontDoorWafManagedRuleOverrideObject.md | Added Sensitivity parameter documentation in the Autorest module docs |
| src/FrontDoor/FrontDoor/help/New-AzFrontDoorWafManagedRuleOverrideObject.md | Added Sensitivity parameter documentation in the main module help |
| src/FrontDoor/FrontDoor/Az.FrontDoor.psd1 | Updated module manifest with version 2.0.0 and generation date; includes minor formatting changes |
| src/FrontDoor/FrontDoor.Autorest/Properties/AssemblyInfo.cs | Updated assembly version from 1.13.1 to 2.0.0 |
| src/FrontDoor/FrontDoor.sln | Updated project GUID for the regenerated AutoRest project |
| src/FrontDoor/FrontDoor.Autorest/docs/Az.FrontDoor.md | Updated module GUID for the regenerated module |
| src/FrontDoor/FrontDoor.Autorest/generate-info.json | Updated generate ID reflecting the regeneration |
| ### -Sensitivity | ||
| Describes the override sensitivity to be applied when rule matches. | ||
| ```yaml | ||
| Type: System.String | ||
| Parameter Sets: (All) | ||
| Aliases: | ||
|
|
||
| Required: False | ||
| Position: Named | ||
| Default value: None | ||
| Accept pipeline input: False | ||
| Accept wildcard characters: False | ||
| ``` |
There was a problem hiding this comment.
The help documentation for the new Sensitivity parameter should include information about the valid values (Low, Medium, High) that are accepted. While the PSArgumentCompleter attribute in the code specifies these values, the documentation should explicitly mention them to help users understand what values they can use.
| ### -Sensitivity | ||
| Describes the override sensitivity to be applied when rule matches. | ||
| ```yaml | ||
| Type: System.String | ||
| Parameter Sets: (All) | ||
| Aliases: | ||
|
|
||
| Required: False | ||
| Position: Named | ||
| Default value: None | ||
| Accept pipeline input: False | ||
| Accept wildcard characters: False | ||
| ``` |
There was a problem hiding this comment.
The help documentation for the new Sensitivity parameter should include information about the valid values (Low, Medium, High) that are accepted. While the PSArgumentCompleter attribute in the code specifies these values, the documentation should explicitly mention them to help users understand what values they can use.
| } # End of PSData hashtable | ||
|
|
||
| } # End of PrivateData hashtable | ||
| } # End of PrivateData hashtable |
There was a problem hiding this comment.
This file contains unrelated formatting changes (ScriptsToProcess, TypesToProcess being uncommented, Tags spacing, and closing brace indentation) that are not related to the Sensitivity parameter addition. These changes should either be removed or explained in a separate commit to keep the PR focused on its stated purpose.
| } # End of PrivateData hashtable | |
| } # End of PrivateData hashtable |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
wyunchi-ms
left a comment
wyunchi-ms
left a comment
There was a problem hiding this comment.
Please update the src/FrontDoor/FrontDoor/ChangeLog.md and put the logs just under the section Upcoming Release and don't bump up any version
3 participants
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.