Skip to content

fix(designer): apply disabled styling to Reassign - #9600

Merged
Brian Lam (lambrianmsft) merged 1 commit into
Azure:mainfrom
lambrianmsft:lambrian-microsoft-disable-connection-reassign
Sep 4, 2026
Merged

fix(designer): apply disabled styling to Reassign#9600
Brian Lam (lambrianmsft) merged 1 commit into
Azure:mainfrom
lambrianmsft:lambrian-microsoft-disable-connection-reassign

Conversation

@lambrianmsft

@lambrianmsft Brian Lam (lambrianmsft) commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Both the original and V2 Connections panels disabled Reassign in read-only mode, but an inline brand-color override kept the action text blue. This removes that override for disabled actions so Fluent renders the entire Reassign action, including its text, with the proper disabled styling.

Impact of Change

  • Users: Read-only designers now show Reassign as consistently disabled instead of visually suggesting the action is clickable.
  • Developers: Focused tests protect the disabled visual contract in both designer implementations.
  • System: No API, state, dependency, or runtime behavior changes.

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: Focused ConnectionEntry unit tests for original and V2 designers; package type-checks; Biome.

Contributors

Screenshots/Videos

image

Read only has the text disabled as well
image

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 3, 2026 21:43
@lambrianmsft Brian Lam (lambrianmsft) added the risk:low Low risk change with minimal impact label Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(designer): apply disabled styling to Reassign
  • Issue: None — starts with a valid fix: prefix (with scope) and is descriptive.
  • Recommendation: No change needed.

Commit Type

  • Exactly one type selected: fix - Bug fix.
  • This matches the diff, which corrects disabled-state styling behavior.

Risk Level

  • Low is selected in the body and the risk:low label is present, matching my advised estimate. This is a single-component UI fix (an inline style override for the disabled Reassign button) touching two connectionEntry.tsx files plus their unit tests — no shared runtime, API, state, or dependency impact. Low is correct.

What & Why

  • Current: Clear explanation that an inline brand-color override kept disabled Reassign text blue, and this removes the override in read-only mode so Fluent applies proper disabled styling.
  • Issue: None.
  • Recommendation: No change needed.

Impact of Change

  • All three audiences addressed (Users, Developers, System).
  • Recommendation:
    • Users: Well described — Reassign now renders as consistently disabled in read-only mode.
    • Developers: Well described — focused tests protect the disabled visual contract.
    • System: Well described — no API/state/dependency/runtime changes.

Test Plan

  • Unit tests added/updated in both the original and V2 connectionEntry.spec.tsx, asserting the disabled button has no inline style attribute. Satisfies CHECK TESTS.

⚠️ Contributors

  • Blank. Consider crediting any PMs, designers, or reviewers who contributed. Does not block merge.

Screenshots/Videos

  • Screenshots provided showing normal and read-only states, satisfying the visual-change requirement.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level Low is correct and matches label
What & Why No change needed
Impact of Change No change needed
Test Plan Unit tests present
Contributors ⚠️ Optionally credit collaborators
Screenshots/Videos Provided

All required checks pass — this PR is compliant and good to merge. 🎉


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Fri, 04 Sep 2026 17:15:50 GMT

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The visual UI change lacks the screenshots required for changes under libs/designer/src/.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Fixes disabled Reassign styling consistently across both designer implementations.

Changes:

  • Removes the brand-color override in read-only mode.
  • Adds focused unit assertions for disabled styling.
File summaries
File Description
libs/designer/.../connectionEntry.tsx Applies disabled styling correctly.
libs/designer/.../connectionEntry.spec.tsx Tests removal of inline styling.
libs/designer-v2/.../connectionEntry.tsx Mirrors the styling fix in V2.
libs/designer-v2/.../connectionEntry.spec.tsx Tests the V2 disabled state.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@lambrianmsft
Brian Lam (lambrianmsft) merged commit 017bfa5 into Azure:main Sep 4, 2026
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants