fix(designer): disable connection reassign when read-only

[Brian Lam (lambrianmsft)]

Commit Type

• feature - New functionality
• fix - Bug fix
• refactor - Code restructuring without behavior change
• perf - Performance improvement
• docs - Documentation update
• test - Test-related changes
• chore - Maintenance/tooling

Risk Level

• Low - Minor changes, limited scope
• Medium - Moderate changes, some user impact
• High - Major changes, significant user/system impact

What & Why

Disable the Connections panel Reassign action whenever the host configures the designer as read-only. Both the original and preview designers had separate ConnectionEntry implementations that ignored their existing read-only state, allowing users to open a connection reassignment flow in otherwise read-only workflows.

Impact of Change

• Users: Reassign is disabled for every connection in read-only original and preview designer sessions.
• Developers: Both ConnectionEntry implementations now consume their existing useReadOnly() selector.
• System: No API, state-shape, dependency, or persistence changes.

Test Plan

• Unit tests added/updated
• E2E tests added/updated
• Manual testing completed
• Tested in: Focused Vitest specs for original and preview ConnectionEntry editable/read-only behavior; TypeScript checks for both designer packages.

Contributors

N/A

Screenshots/Videos

Not included. The visual change is limited to the Fluent UI disabled state on the existing Reassign action and is covered by focused component assertions in both designer packages.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[github-actions]

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

• Current: fix(designer): disable connection reassign when read-only
• Issue: None — uses a valid fix: prefix with scope and is descriptive.
• Recommendation: No change needed.

---

✅ Commit Type

• Exactly one type selected (fix - Bug fix), which matches the title prefix and the diff.
• Note: Correctly categorized; the change fixes read-only enforcement on the Reassign action.

---

✅ Risk Level

• Low selected in the body, risk:low label present, and both match the advised estimate. The diff is a single-component UI fix across libs/designer and libs/designer-v2 (disable a button when read-only) plus co-located unit tests — no shared runtime, API, security, or state-shape impact. Low is correct.

---

✅ What & Why

• Current: Clear explanation that the Reassign action was ignoring existing read-only state in both the original and preview designers.
• Issue: None.
• Recommendation: No change needed.

---

✅ Impact of Change

• All three audiences addressed (Users, Developers, System).
• Recommendation:
  • Users: Already stated — Reassign disabled for all connections in read-only sessions.
  • Developers: Already stated — both ConnectionEntry implementations consume useReadOnly().
  • System: Already stated — no API/state/dependency/persistence changes.

---

✅ Test Plan

• Unit tests added/updated is checked and confirmed in the diff: new connectionEntry.spec.tsx for both libs/designer and libs/designer-v2 covering editable and read-only behavior. Satisfies CHECK TESTS.

---

⚠️ Contributors

• Marked N/A. If any PM, designer, or reviewer contributed, please credit them. Does not block merge.

---

⚠️ Screenshots/Videos

• The change touches UI in libs/designer/src and libs/designer-v2/src, but is limited to the Fluent UI disabled state of an existing Reassign button and is well covered by component assertions. A quick before/after screenshot of the disabled state would be a nice-to-have but is not required. Does not block merge.

---

Summary Table

Section	Status	Recommendation
Title	✅	No change needed
Commit Type	✅	No change needed
Risk Level	✅	low is correct (matches label + body)
What & Why	✅	No change needed
Impact of Change	✅	No change needed
Test Plan	✅	Unit tests confirmed in diff
Contributors	⚠️	Credit contributors if any
Screenshots/Videos	⚠️	Optional screenshot of disabled state

---

All required checks pass. This PR is compliant and cleared to merge — consider the two optional nudges (Contributors, Screenshots).

---

Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Thu, 03 Sep 2026 20:31:03 GMT