Add new errorResponse toggle to secure properties - #9596
Add new errorResponse toggle to secure properties#9596Sasi Kumar Reddy D (Sasi-D) wants to merge 3 commits into
Conversation
🔒 AI Validation PendingThis PR is from an external contributor. AI validation will be performed after manual review. Maintainers: Add the |
|
Sasi Kumar Reddy D (@Sasi-D) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
🟡 Changes recommended
The implementation is coherent, but the title must use the required feat: prefix.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds secure error-response controls and serialization support to both designer versions.
Changes:
- Adds the localized Security toggle.
- Loads and serializes
errorResponsewhile preserving unknown properties. - Adds UI and serialization tests.
File summaries
| File | Description |
|---|---|
Localize/lang/strings.json |
Adds localized toggle text. |
libs/designer/src/lib/ui/settings/sections/security.tsx |
Renders the v1 toggle. |
libs/designer/src/lib/ui/settings/index.tsx |
Connects the v1 toggle to settings. |
libs/designer/src/lib/ui/settings/__tests__/security.spec.tsx |
Tests v1 toggle behavior. |
libs/designer/src/lib/core/actions/bjsworkflow/settings.ts |
Loads and gates the v1 setting. |
libs/designer/src/lib/core/actions/bjsworkflow/serializer.ts |
Serializes secure-data properties in v1. |
libs/designer/src/lib/core/actions/bjsworkflow/__test__/secureErrorResponse.spec.ts |
Tests v1 support and serialization. |
libs/designer/src/lib/common/constants.ts |
Defines the v1 property name. |
libs/designer-v2/src/lib/ui/settings/sections/security.tsx |
Renders the v2 toggle. |
libs/designer-v2/src/lib/ui/settings/index.tsx |
Connects the v2 toggle to settings. |
libs/designer-v2/src/lib/ui/settings/__tests__/security.spec.tsx |
Tests v2 toggle behavior. |
libs/designer-v2/src/lib/core/actions/bjsworkflow/settings.ts |
Loads and gates the v2 setting. |
libs/designer-v2/src/lib/core/actions/bjsworkflow/serializer.ts |
Serializes secure-data properties in v2. |
libs/designer-v2/src/lib/core/actions/bjsworkflow/__test__/secureErrorResponse.spec.ts |
Tests v2 support and serialization. |
libs/designer-v2/src/lib/common/constants.ts |
Defines the v2 property name. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Commit Type
Risk Level
What & Why
Adds a Secure error responses setting to the Security section for supported HTTP and webhook actions in both designer versions.
When enabled, the designer writes
errorResponseto the action's existingruntimeConfiguration.secureData.propertiesarray. This allows the runtime to secure error response details for failed requests.The setting is available only for these action types:
HttpHttpWebhookApiConnectionWebhookOpenApiConnectionWebhookImpact of Change
designeranddesigner-v2. No public API changes are introduced.errorResponseto the existing secure-data properties array when enabled. Serialization preserves Secure inputs, Secure outputs, unknown secure-data values, and hidden values on unsupported operations. No new dependencies or performance-sensitive paths are introduced.Test Plan
Contributors
Sasi Kumar Reddy D (@Sasi-D)
Screenshots/Videos