Skip to content

feat: adding support for amdama (supernova) gpus.#7697

Closed
mipresmsft wants to merge 27 commits intomainfrom
mipres-main-AddAMDAMASupport
Closed

feat: adding support for amdama (supernova) gpus.#7697
mipresmsft wants to merge 27 commits intomainfrom
mipres-main-AddAMDAMASupport

Conversation

@mipresmsft
Copy link
Contributor

What this PR does / why we need it:

Adding support for AMDAMA (Supernova) GPUs.

@mipresmsft mipresmsft changed the title Moved changes to sync with main branch. Adding support for AMDAMA (Supernova) GPUs. Jan 21, 2026
Copilot AI review requested due to automatic review settings January 30, 2026 21:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for AMD AMA (Supernova) GPU hardware by enabling detection and configuration for the Standard_NM16ads_MA35D VM SKU. The changes introduce a new VM size detection mechanism, install necessary drivers and packages for AMD AMA GPUs, and configure the required system settings for Azure Linux environments.

Changes:

  • Added VM SKU detection logic for AMD AMA-enabled instances (Standard_NM16ads_MA35D)
  • Implemented driver installation and configuration for AMD AMA GPUs on Azure Linux
  • Added E2E tests to validate AMD AMA GPU functionality
  • Updated firewall rules to allow access to download.microsoft.com for AMD AMA package installation

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
aks-node-controller/helpers/const.go Added constant for Standard_NM16ads_MA35D VM size
aks-node-controller/parser/helper.go Added helper function to detect AMD AMA enabled SKUs
aks-node-controller/parser/parser.go Added AMDAMA_NODE environment variable to CSE configuration
pkg/agent/baker.go Added IsAmdAmaEnabledSKU function for template rendering
pkg/agent/datamodel/helper.go Added IsAmdAmaEnabledSKU function for VM SKU detection
pkg/agent/variables.go Added amdamaNode variable to CSE command variables
parts/linux/cloud-init/artifacts/cse_cmd.sh Declared AMDAMA_NODE variable for shell scripts
parts/linux/cloud-init/artifacts/cse_config.sh Implemented setupAmdAma function to install drivers and configure system
parts/linux/cloud-init/artifacts/cse_main.sh Added call to setupAmdAma during node preparation
e2e/scenario_test.go Added E2E tests for AMD AMA GPU support (standard and scriptless)
e2e/aks_model.go Added firewall rule to allow download.microsoft.com access

Copilot AI review requested due to automatic review settings January 30, 2026 21:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 71 changed files in this pull request and generated 5 comments.

Copilot AI review requested due to automatic review settings February 18, 2026 20:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 70 changed files in this pull request and generated 6 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 21 out of 72 changed files in this pull request and generated 3 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 21 out of 72 changed files in this pull request and generated 2 comments.

Signed-off-by: mipres <mipres@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants