Skip to content

Feature/togglensg#6

Open
da5is wants to merge 11 commits into
Azure-Samples:mainfrom
da5is:feature/togglensg
Open

Feature/togglensg#6
da5is wants to merge 11 commits into
Azure-Samples:mainfrom
da5is:feature/togglensg

Conversation

@da5is

@da5is da5is commented Jan 12, 2026

Copy link
Copy Markdown

Purpose

The current sample does not deploy in 2026 due to changes - this update removes the non-bicep deployments, brings the bicep files to current standards (managed diagnostics accounts for virtual machines as an example), and adds toggles for making bastion and NSGs optional. It also changes the diagram from Visio into Mermaid while simplifying the documentation and making it easier for future contributors.

Does this introduce a breaking change?

[X] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Clone the repository
  • Make sure to specify a value for the following parameters in the main.parameters.json file:
    • prefix: specifies a prefix for all the Azure resources.
    • authenticationType: specifies the type of authentication when accessing the Virtual Machine. SSH key is recommended. Allowed values: sshPublicKey and password.
    • vmAdminUsername: specifies the name of the administrator account of the virtual machine.
    • vmAdminPasswordOrKey: specifies the SSH Key or password for the virtual machine. SSH key is recommended. We suggest reading the password or SSH Key from Key Vault.

What to Check

Verify that the following are valid

  • Validate that infrastructure deployed and that the Private Endpoint is accessible via the client virtual machine through curling the Private Endpoint.

da5is added 11 commits December 11, 2025 08:40
- Remove deprecated Bicep modules (storageAccount.bicep, privateEndpoint.bicep)
- Remove visio directory and image files
- Rewrite README.md with Mermaid architecture diagram
- Update deployment instructions and examples
- Simplify documentation to focus on current Bicep deployment
- Reflect managed boot diagnostics support (no separate storage account)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant