Feature/togglensg#6
Open
da5is wants to merge 11 commits into
Open
Conversation
- Remove deprecated Bicep modules (storageAccount.bicep, privateEndpoint.bicep) - Remove visio directory and image files - Rewrite README.md with Mermaid architecture diagram - Update deployment instructions and examples - Simplify documentation to focus on current Bicep deployment - Reflect managed boot diagnostics support (no separate storage account)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The current sample does not deploy in 2026 due to changes - this update removes the non-bicep deployments, brings the bicep files to current standards (managed diagnostics accounts for virtual machines as an example), and adds toggles for making bastion and NSGs optional. It also changes the diagram from Visio into Mermaid while simplifying the documentation and making it easier for future contributors.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid