Skip to content
This repository was archived by the owner on Jun 15, 2026. It is now read-only.

docs: remove unnecessary config lines#8

Open
krukowskid wants to merge 3 commits into
Azure-Samples:mainfrom
krukowskid:main
Open

docs: remove unnecessary config lines#8
krukowskid wants to merge 3 commits into
Azure-Samples:mainfrom
krukowskid:main

Conversation

@krukowskid

@krukowskid krukowskid commented Nov 22, 2023

Copy link
Copy Markdown

Purpose

Hey @paolosalvatori, thank you for this content!
I have removed azure.workload.identity/use: "true" from code samples, because its not valid for service account https://azure.github.io/azure-workload-identity/docs/topics/service-account-labels-and-annotations.html#service-account

I have also removed azure.workload.identity/tenant-id: ${tenantId} annotation because it defaults to tenantId value set during wi installation.

    helm install $releaseName $repoName/$chartName \
        --namespace $namespace \
        --create-namespace \
        --set azureTenantID="$tenantId"

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

@krukowskid

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@paolosalvatori

Copy link
Copy Markdown
Contributor

Thanks @krukowskid, I wrote the article when the Workload Identity was still in preview, so in the meantime, a few things have changed, and I missed refreshing the sample. 😸

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants