fix(test): fix reload_keystore flaky test by including all validators in initial keystore#21827
Closed
fix(test): fix reload_keystore flaky test by including all validators in initial keystore#21827
Conversation
… in initial keystore The test was failing because the sequencer couldn't propose when the 4th validator (not in keystore) was selected as proposer. With the pipeline refactor (PR #21026) changing committee timestamp resolution, the deterministic BN254 keys no longer guaranteed a favorable proposer ordering. Fix: include all 4 staked validators in the initial keystore so the sequencer can always propose. Test 'add new validator' functionality by adding a non-staked phantom validator during keystore reload.
AztecBot
added
ci-draft
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
e2e_sequencer/reload_keystore.test.tsfailure in merge-train/spartan CI.Root cause: The test staked 4 validators but only loaded 3 into the keystore. When the 4th validator was selected as proposer (via hash-based RANDAO selection), the sequencer silently skipped block building — producing zero visible logs at VERBOSE level. The pipeline refactor (#21026) changed the timestamp used for committee resolution from epoch-start to slot-start, which altered the deterministic proposer ordering established by #21749's fix.
Fix: Include all 4 staked validators in the initial keystore so the sequencer can always propose regardless of proposer selection. The "add new validator" test is preserved by adding a non-staked phantom validator during keystore reload, which verifies:
Test plan
e2e_sequencer/reload_keystore.test.tspasses locally (32s, down from 322s timeout)ClaudeBox log: https://claudebox.work/s/14c53acc733d6973?run=1