chore(pipeline): shorten last block in checkpoint build duration to allow checkpoint construction#21591
Open
Maddiaa0 wants to merge 1 commit intomd/update-latency-explorerfrom
Open
Conversation
This was referenced Mar 16, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Maddiaa0
force-pushed
the
md/update-latency-explorer
branch
from
3850b5a to
94d5685
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
e636f49 to
3a1ba92
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
3a1ba92 to
6b3361c
Compare
Maddiaa0
force-pushed
the
md/update-latency-explorer
branch
from
94d5685 to
5c7471a
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
6b3361c to
94cdd36
Compare
Maddiaa0
force-pushed
the
md/update-latency-explorer
branch
from
5c7471a to
2e68fe2
Compare
Maddiaa0
changed the base branch from
md/update-latency-explorer
to
graphite-base/21591
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
94cdd36 to
6da9164
Compare
Maddiaa0
force-pushed
the
graphite-base/21591
branch
from
2e68fe2 to
191d1bb
Compare
Maddiaa0
changed the base branch from
graphite-base/21591
to
md/update-latency-explorer
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
6da9164 to
dea8538
Compare
Maddiaa0
force-pushed
the
md/update-latency-explorer
branch
from
191d1bb to
63f38ed
Compare
checkpoint build time Add a new optional `lastBlockDurationMs` config field to SequencerConfig. When set and less than blockDurationMs, the last block in a multi-block slot gets a shorter window, causing the checkpoint to broadcast earlier. This gives the next proposer more usable early-start time.
Maddiaa0
force-pushed
the
md/update-latency-explorer
branch
from
63f38ed to
df9a22b
Compare
Maddiaa0
force-pushed
the
md/further-pipeline-overlapping
branch
from
dea8538 to
3009e59
Compare
spalladino
reviewed
Mar 31, 2026
Contributor
spalladino
left a comment
spalladino
left a comment
There was a problem hiding this comment.
Reading the PR I'm not sure I understand the rationale for this. Why do we need to shorten specifically the last block? If we want to allow more time at the end of the slot for assembling the checkpoint, we can bump the CHECKPOINT_ASSEMBLE_TIME, and reduce the time for all blocks proportionally (or the number of blocks for that matter), so we don't have an edge case when handling the very last block.
Comment on lines
+182
to
+184
| const pendingCheckpoint = await this.getPendingCheckpoint(); | ||
| const pendingCheckpointNumber = | ||
| pendingCheckpoint?.checkpointNumber ?? CheckpointNumber(INITIAL_CHECKPOINT_NUMBER - 1); |
Contributor
There was a problem hiding this comment.
Why this change? Do we need to deserialize an entire checkpoint (which iirc includes its blocks and its tx effects) just to get its number?
| enableProposerPipelining: true, // <- yehaw | ||
| mockGossipSubNetwork: true, | ||
| mockGossipSubNetworkLatency: 500, // 200 ms delay in message prop - adverse network conditions | ||
| mockGossipSubNetworkLatency: 200, // 200 ms delay in message prop - adverse network conditions |
Comment on lines
+83
to
+85
| blockDurationMs: 5800, | ||
| lastBlockDurationMs: 3000, | ||
| maxTxsPerCheckpoint: 24, |
Contributor
There was a problem hiding this comment.
I'd appreciate a comment on why these values, 5800 looks odd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Small compromise to smoothen checkpoint construction, the last block should really be shorter. Palla's pr's with the multiplier also address this, however
I think that realistically we are only concerned with the last block being shorter.