chore: migrate all CI workflows from static AWS keys to OIDC#21239
Open
randyquaye wants to merge 1 commit intonextfrom
Open
chore: migrate all CI workflows from static AWS keys to OIDC#21239randyquaye wants to merge 1 commit intonextfrom
randyquaye wants to merge 1 commit intonextfrom
Conversation
randyquaye
force-pushed
the
rq/migrate-aws-creds
branch
from
e24de43 to
f5eb62a
Compare
Collaborator
|
/claudebox review this PR for all CI entrypoints - does it break? evaluate the security |
Collaborator
|
ClaudeBox: review this PR for all CI entrypoints - does it break? evaluate the security ... workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secrets.AWS_ACCESS_KEY_ID/secrets.AWS_SECRET_ACCESS_KEYusage from CI workflowsaws-actions/configure-aws-credentialsOIDC step to every job that needs AWS accesspermissions: id-token: writeto all jobs (and caller workflows for reusable workflows)configure-aws-credentialstov6.0.0(8df5847) withrole-duration-secondsset for long-running jobsAWS_OIDC_ROLE_ARN_PRIVATE_FORKfor the private fork release workflowFixes the Post-Actions
cache_uploadskipping with "no aws credentials found" — the OIDC step was previously conditional onCI_USE_SSH != '1', so when SSH mode was active, no credentials flowed to later steps.Test plan
cijob)cache_uploadin Post-Actions no longer skips