fix(tx): reject txs with invalid setup when unprotecting#21224
Merged
spalladino merged 3 commits intomerge-train/spartanfrom Mar 12, 2026
Merged
fix(tx): reject txs with invalid setup when unprotecting#21224spalladino merged 3 commits intomerge-train/spartanfrom
spalladino merged 3 commits intomerge-train/spartanfrom
Conversation
spalladino
added
ci-no-fail-fast
PhilWindle
approved these changes
Mar 10, 2026
Collaborator
PhilWindle
left a comment
PhilWindle
left a comment
There was a problem hiding this comment.
Looks good. Just a couple of things.
- Could you add a test to tx_pool_v2.test please? I try and keep that test suite pretty exhaustive.
- Do we need to update the README for validations?
Contributor
Author
I originally had this commit as part of a bigger one and had updated the README there. Let me bring that change here. |
spalladino
force-pushed
the
palla/reject-invalid-setup-in-unprotect
branch
from
b605576 to
cd0c80b
Compare
When unprotecting txs, we were not running the check for allowed public setup functions, which was skipped in the reqresp entrypoint. This commit now tracks whether public setup is allowed or not for a tx in the tx metadata, and uses it to drop the tx when it becomes unprotected. An alternative approach would have been to store the entire public setup calls in the tx metadata, but this means a smaller memory footprint.
spalladino
force-pushed
the
palla/reject-invalid-setup-in-unprotect
branch
from
cd0c80b to
3c1e07b
Compare
spalladino
force-pushed
the
palla/reject-invalid-setup-in-unprotect
branch
from
3c1e07b to
03eed16
Compare
Co-Authored-By: Claude Opus 4.6 <[email protected]>
spalladino
force-pushed
the
palla/reject-invalid-setup-in-unprotect
branch
from
03eed16 to
e393a46
Compare
…reject-invalid-setup-in-unprotect
spalladino
force-pushed
the
palla/reject-invalid-setup-in-unprotect
branch
from
c517b03 to
856cb1a
Compare
AztecBot
pushed a commit
that referenced
this pull request
Mar 12, 2026
When unprotecting txs, we were not running the check for allowed public setup functions, which was skipped in the reqresp entrypoint. This commit now tracks whether public setup is allowed or not for a tx in the tx metadata, and uses it to drop the tx when it becomes unprotected. An alternative approach would have been to store the entire public setup calls in the tx metadata, but this means a smaller memory footprint.
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #21453. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unprotecting txs, we were not running the check for allowed public setup functions, which was skipped in the reqresp entrypoint.
This commit now tracks whether public setup is allowed or not for a tx in the tx metadata, and uses it to drop the tx when it becomes unprotected.
An alternative approach would have been to store the entire public setup calls in the tx metadata, but this means a smaller memory footprint.