refactor: separate protocol test utils#21099
Conversation
LeilaWang
force-pushed
the
lw/protocol_test_utils
branch
from
a69cb7a to
e32d754
Compare
nventuro
left a comment
nventuro
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| pub mod delayed_public_mutable; | ||
|
|
||
| pub mod tests; | ||
| pub mod test_utils; |
There was a problem hiding this comment.
Why not have these in the new crate?
There was a problem hiding this comment.
These are also used by some tests in types, and are more general, not protocol specific. So I thought to keep them in types.
There was a problem hiding this comment.
Can we make that pub(crate) then so that they don't end up exposed via aztec-nr? I'd rather try to keep the API surface as small as possible to prevent accidental dependencies on these kinds of things.
There was a problem hiding this comment.
They are also used outside of types by the tests of the circuits. Currently there are only 3 functions: pad_end, pad_end_with, and make_fixture. But if you still prefer not to expose these to aztec-nr users, I will copy them into protocol-test-utils.
LeilaWang
force-pushed
the
lw/protocol_test_utils
branch
from
e32d754 to
f4973c6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Moving all protocol specific fixtures, builder, test utils from `types` to a separate `protocol-test-utils` crate, as `types` is expected to be used by aztec-nr users.
|
✅ Successfully backported to backport-to-v4-next-staging #21453. |
3 participants
Moving all protocol specific fixtures, builder, test utils from
typesto a separateprotocol-test-utilscrate, astypesis expected to be used by aztec-nr users.