Skip to content

theme: add GTK3 selection colours so selected rows stay readable in Thunar etc #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanikamaxxing wants to merge 1 commit into
base: main
Choose a base branch
from
Open

theme: add GTK3 selection colours so selected rows stay readable in Thunar etc #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion modules/theme/GtkGenerator.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,32 @@ QtObject {
css += `@define-color card_bg_color ${surfaceContainer};\n`
css += `@define-color card_fg_color ${onSurface};\n`

// Sidebar typically matches window or has slight contrast.
// Sidebar typically matches window or has slight contrast.
// Using window variables as reference.
css += `@define-color sidebar_bg_color @window_bg_color;\n`
css += `@define-color sidebar_fg_color @window_fg_color;\n`
css += `@define-color sidebar_border_color @window_bg_color;\n`
css += `@define-color sidebar_backdrop_color @window_bg_color;\n`

// GTK3 selection colours — without these, GTK3 apps (Thunar, etc) fall back to
// the theme's defaults which often leave selected rows with white text on the
// light accent colour (very low contrast). Map them to accent_bg/_fg so selected
// rows get the same dark-on-bright contrast that libadwaita uses for GTK4.
css += `@define-color theme_selected_bg_color @accent_bg_color;\n`
css += `@define-color theme_selected_fg_color @accent_fg_color;\n`
css += `@define-color theme_bg_color @window_bg_color;\n`
css += `@define-color theme_fg_color @window_fg_color;\n`
css += `@define-color theme_base_color @view_bg_color;\n`
css += `@define-color theme_text_color @view_fg_color;\n`

// Explicit selection styling override for views (file lists, tree views, etc)
// to force readable contrast regardless of theme defaults.
css += `\n`
css += `*:selected, *:selected:focus, row:selected, row:selected:focus {\n`
css += ` background-color: @accent_bg_color;\n`
css += ` color: @accent_fg_color;\n`
css += `}\n`

const home = Quickshell.env("HOME")
const gtk3Dir = home + "/.config/gtk-3.0"
const gtk4Dir = home + "/.config/gtk-4.0"
Expand Down