feat: add Scotiabank AI Engineer role and update researcher end date - #20
Conversation
Add Scotiabank work experience entry with logo, and set the UCalgary Undergraduate Researcher end date to Apr. 2026 now that it has a defined end.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Summary by QodoAdd Scotiabank AI Engineer experience and set research end date
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
There was a problem hiding this comment.
Pull request overview
This PR updates the portfolio’s single-source resume data (src/data/resume.tsx) to reflect new work experience and close out a research role. It also includes unrelated repo/tooling changes (lockfile churn, removal of agent docs, and new Claude plugin settings) that should be separated or explicitly justified.
Changes:
- Add a new Scotiabank “AI Engineer” work entry (with logo) to the resume data.
- Update the University of Calgary Undergraduate Researcher end date to Apr. 2026.
- Include additional non-resume changes: lockfile metadata edits, removal of
AGENTS.md, and addition of.claude/settings.json.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/data/resume.tsx | Adds Scotiabank work entry and updates researcher end date in the central resume DATA object. |
| package-lock.json | Large lockfile churn (removal of many "peer": true markers) unrelated to resume content changes. |
| AGENTS.md | Deletes AI-agent guidance document (not mentioned in PR description). |
| .claude/settings.json | Adds Claude settings enabling a plugin by default (not mentioned in PR description). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "enabledPlugins": { | ||
| "superpowers@claude-plugins-official": true | ||
| } |
Code Review by Qodo
Context used✅ Compliance rules (platform):
3 rules 1. Scotiabank link blocked
|
| start: "Jun. 2026", | ||
| end: "Present", | ||
| description: "NDA", | ||
| }, |
There was a problem hiding this comment.
1. Scotiabank link blocked 🐞 Bug ≡ Correctness
The new Scotiabank work entry sets a truthy description ("NDA"), which causes ResumeCard to call
preventDefault on click and toggle expansion instead of navigating, making the provided Scotiabank
href unreachable from the card.
Agent Prompt
### Issue description
The Scotiabank ResumeCard is configured with an external `href`, but because `description` is non-empty, the ResumeCard click handler prevents default navigation and toggles expansion instead. This makes the Scotiabank link non-functional from the UI.
### Issue Context
`ResumeCard` is wrapped in a `Link` and attaches `onClick={handleClick}`. `handleClick` calls `e.preventDefault()` whenever `description` is truthy.
### Fix options
- **Simplest (data-only):** For the Scotiabank entry, omit `description` (or set it to an empty string) so the card click navigates to the href.
- **Behavioral (component):** Change `ResumeCard` so navigation is not prevented when `href` is provided (e.g., only toggle expansion via a dedicated control like the chevron).
### Fix Focus Areas
- src/data/resume.tsx[108-119]
- src/components/resume-card.tsx[34-46]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Add contributing/workflow sections to README.md and CLAUDE.md explaining the devel -> main branch flow, the requirement to always squash-merge PRs, and the Conventional Commits format semantic-release relies on.
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Test plan