Skip to content

feat: add Scotiabank AI Engineer role and update researcher end date - #20

Merged
Axeloooo merged 2 commits into
develfrom
feature/add-scotiabank-experience
Aug 2, 2026
Merged

feat: add Scotiabank AI Engineer role and update researcher end date#20
Axeloooo merged 2 commits into
develfrom
feature/add-scotiabank-experience

Conversation

@Axeloooo

@Axeloooo Axeloooo commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add Scotiabank AI Engineer work experience entry with logo
  • Update UCalgary Undergraduate Researcher end date to Apr. 2026

Test plan

  • Verified locally that resume renders correctly

Add Scotiabank work experience entry with logo, and set the UCalgary
Undergraduate Researcher end date to Apr. 2026 now that it has a
defined end.
Copilot AI review requested due to automatic review settings August 2, 2026 21:37
@vercel

vercel Bot commented Aug 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
portfolio Ready Ready Preview Aug 2, 2026 9:44pm

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Add Scotiabank AI Engineer experience and set research end date

✨ Enhancement ⚙️ Configuration changes 📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Add Scotiabank AI Engineer work experience entry with a new logo asset.
• Update UCalgary Undergraduate Researcher end date to Apr. 2026.
• Add Claude plugin settings, remove agent guidance doc, and normalize package-lock metadata.
Diagram

graph TD
  A["Resume data (src/data/resume.tsx)"] --> B["Resume UI (Next.js pages/components)"] --> C[("Static assets (public/)")]
  D["Claude settings (.claude/settings.json)"] --> E["Developer tooling"]
  F["package-lock.json"] --> E
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Use an optimized SVG (or Next.js-optimized image pipeline) for the logo
  • ➕ Better scaling/sharpness across devices
  • ➕ Typically smaller payloads and improved Lighthouse scores
  • ➕ Easier theming (e.g., dark mode variants) if needed
  • ➖ May require sourcing/creating an SVG and validating brand guidelines
  • ➖ Potential extra work to ensure consistent rendering vs PNG
2. Reduce lockfile churn by pinning Node/NPM versions (or using npm ci consistently)
  • ➕ Avoids noisy diffs from metadata-only lockfile changes
  • ➕ Improves reproducibility across contributors/CI
  • ➖ Requires team/repo convention (e.g., .nvmrc, volta, or engine fields)
  • ➖ Doesn't change runtime behavior; mostly workflow hygiene

Recommendation: The PR’s approach is appropriate for a content-driven portfolio (update the central resume data, add a public logo asset). If you want to tighten it further, consider switching the logo to an optimized SVG (or ensuring PNG optimization) and adopt a pinned Node/NPM setup to prevent future package-lock-only churn.

Files changed (4) +17 / -15 · 1 not counted

Enhancement (2) +12 / -1
scotiabank-logo.pngAdd Scotiabank logo asset for resume entry not counted

Add Scotiabank logo asset for resume entry

• Introduces a new PNG logo under public/ so the new Scotiabank experience entry can render with branding.

public/scotiabank-logo.png

resume.tsxAdd Scotiabank AI Engineer role and update research end date +12/-1

Add Scotiabank AI Engineer role and update research end date

• Adds a new Scotiabank "AI Engineer" work experience item referencing the new logo asset. Updates the UCalgary Undergraduate Researcher role end date from "Present" to "Apr. 2026".

src/data/resume.tsx

Other (2) +5 / -14
settings.jsonEnable Claude plugin via repo settings +5/-0

Enable Claude plugin via repo settings

• Adds Claude configuration to enable the official "superpowers" plugin for agent-assisted workflows.

.claude/settings.json

package-lock.jsonNormalize lockfile metadata (peer flags removed) +0/-14

Normalize lockfile metadata (peer flags removed)

• Updates package-lock entries by removing several "peer": true metadata fields without changing dependency versions in the shown hunks. This is likely due to npm lockfile generation differences.

package-lock.json

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the portfolio’s single-source resume data (src/data/resume.tsx) to reflect new work experience and close out a research role. It also includes unrelated repo/tooling changes (lockfile churn, removal of agent docs, and new Claude plugin settings) that should be separated or explicitly justified.

Changes:

  • Add a new Scotiabank “AI Engineer” work entry (with logo) to the resume data.
  • Update the University of Calgary Undergraduate Researcher end date to Apr. 2026.
  • Include additional non-resume changes: lockfile metadata edits, removal of AGENTS.md, and addition of .claude/settings.json.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/data/resume.tsx Adds Scotiabank work entry and updates researcher end date in the central resume DATA object.
package-lock.json Large lockfile churn (removal of many "peer": true markers) unrelated to resume content changes.
AGENTS.md Deletes AI-agent guidance document (not mentioned in PR description).
.claude/settings.json Adds Claude settings enabling a plugin by default (not mentioned in PR description).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .claude/settings.json
Comment on lines +1 to +4
{
"enabledPlugins": {
"superpowers@claude-plugins-official": true
}
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Context used
✅ Compliance rules (platform): 3 rules

Grey Divider


Remediation recommended

1. Scotiabank link blocked 🐞 Bug ≡ Correctness
Description
The new Scotiabank work entry sets a truthy description ("NDA"), which causes ResumeCard to call
preventDefault on click and toggle expansion instead of navigating, making the provided Scotiabank
href unreachable from the card.
Code

src/data/resume.tsx[R116-119]

+      start: "Jun. 2026",
+      end: "Present",
+      description: "NDA",
+    },
Evidence
The Scotiabank entry includes both an external href and a non-empty description. The homepage passes
that description into ResumeCard, whose click handler prevents default navigation whenever
description is present, so clicking the card cannot follow the href.

src/data/resume.tsx[108-119]
src/app/page.tsx[79-95]
src/components/resume-card.tsx[34-46]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The Scotiabank ResumeCard is configured with an external `href`, but because `description` is non-empty, the ResumeCard click handler prevents default navigation and toggles expansion instead. This makes the Scotiabank link non-functional from the UI.

### Issue Context
`ResumeCard` is wrapped in a `Link` and attaches `onClick={handleClick}`. `handleClick` calls `e.preventDefault()` whenever `description` is truthy.

### Fix options
- **Simplest (data-only):** For the Scotiabank entry, omit `description` (or set it to an empty string) so the card click navigates to the href.
- **Behavioral (component):** Change `ResumeCard` so navigation is not prevented when `href` is provided (e.g., only toggle expansion via a dedicated control like the chevron).

### Fix Focus Areas
- src/data/resume.tsx[108-119]
- src/components/resume-card.tsx[34-46]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

To customize comments, go to the Qodo configuration screen, or learn more in the docs.

Qodo Logo

Comment thread src/data/resume.tsx
Comment on lines +116 to +119
start: "Jun. 2026",
end: "Present",
description: "NDA",
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Scotiabank link blocked 🐞 Bug ≡ Correctness

The new Scotiabank work entry sets a truthy description ("NDA"), which causes ResumeCard to call
preventDefault on click and toggle expansion instead of navigating, making the provided Scotiabank
href unreachable from the card.
Agent Prompt
### Issue description
The Scotiabank ResumeCard is configured with an external `href`, but because `description` is non-empty, the ResumeCard click handler prevents default navigation and toggles expansion instead. This makes the Scotiabank link non-functional from the UI.

### Issue Context
`ResumeCard` is wrapped in a `Link` and attaches `onClick={handleClick}`. `handleClick` calls `e.preventDefault()` whenever `description` is truthy.

### Fix options
- **Simplest (data-only):** For the Scotiabank entry, omit `description` (or set it to an empty string) so the card click navigates to the href.
- **Behavioral (component):** Change `ResumeCard` so navigation is not prevented when `href` is provided (e.g., only toggle expansion via a dedicated control like the chevron).

### Fix Focus Areas
- src/data/resume.tsx[108-119]
- src/components/resume-card.tsx[34-46]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Add contributing/workflow sections to README.md and CLAUDE.md explaining
the devel -> main branch flow, the requirement to always squash-merge
PRs, and the Conventional Commits format semantic-release relies on.
@Axeloooo
Axeloooo merged commit d806ece into devel Aug 2, 2026
3 checks passed
@Axeloooo
Axeloooo deleted the feature/add-scotiabank-experience branch August 2, 2026 21:47
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants