fix Sign for URLs containing spechial chars: !'()#*+? and non latin chars#335
Open
victornikitin wants to merge 1 commit intoAutomattic:masterfrom
Open
fix Sign for URLs containing spechial chars: !'()#*+? and non latin chars#335victornikitin wants to merge 1 commit intoAutomattic:masterfrom
victornikitin wants to merge 1 commit intoAutomattic:masterfrom
Conversation
victornikitin
force-pushed
the
SignedUrlWithSpechialChars
branch
from
472db02 to
50f348d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem with get signed url to download file.
When file URL contains spechial chars, sign for it is created without converting these chars.
Also the same problem is with non latin chars.
So file url and it url in sign are different. Because of that sign is incorrect.
Issue: #334