fix(core): ElasticLogLoader handles logStartOffset > logEndOffset (GH…#3259
Open
mahendrarathore1742 wants to merge 1 commit into
Open
fix(core): ElasticLogLoader handles logStartOffset > logEndOffset (GH…#3259mahendrarathore1742 wants to merge 1 commit into
mahendrarathore1742 wants to merge 1 commit into
Conversation
…toMQGH-2326) - Fixes IllegalStateException when logStartOffset is ahead of logEndOffset after retention/compaction with unclean shutdown. - Adds regression test for AutoMQGH-2326. - Test: ElasticLogLoaderTest covers both regression and normal load cases.
mahendrarathore1742
requested review from
1sonofqiu,
Gezi-lzq,
superhx and
woshigaopp
as code owners
|
|
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
Author
|
@superhx ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-2326)
Updated ElasticLogLoader to handle cases where logStartOffset is ahead of logEndOffset without throwing an exception.
Ensured that segments are properly removed and a new segment is created at the correct offset.
-Tests :-
Added a regression test (ElasticLogLoaderTest) to verify that loading succeeds when logStartOffset > logEndOffset.
The test also covers normal load scenarios to ensure no regressions.
Notes :-
This PR fixes a critical edge case for log recovery and prevents resource leaks in S3-backed deployments.
fix #2326