Repository navigation
feat(chat): never-replied chats default to General; dot inside inbox pills - #14783
Merged
Merged
Conversation
…pills Uncategorized chats now go to Priority only once you have replied in them. New inbound chats and blast threads land in General, which is what Michael asked for originally (Priority is the curated view). An explicit category still wins, and an api without has_replied keeps the old behavior. The unread dot moves inside the Priority/General pill after the label instead of hanging off its corner. It turns white on the selected pill. Menus and swipe actions offer only the tab the chat is not shown in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 38ff4c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs AudiusProject/api#1082 for the new behavior. Before that deploys, nothing changes, because a missing
has_repliedfalls back to Priority.Why: In the #eng thread on 9/10, Michael settled on Priority as the default view, curated to the user, with "a dot on general for new messages". What shipped put every uncategorized chat in Priority, so General only filled up if you sorted chats by hand.
Tab rule (
getInboxTabForChat):Dots: The tab dots use
uncategorized_unrepliedfromunread_by_category. The dot now sits inside the pill after the label instead of hanging off the corner, and turns white on the selected (purple) pill. That needed a newendAdornmentprop onSelectablePill, added to both harmony and harmony-native.Menus/swipes: These now offer only the tab the chat isn't shown in. Pushes are unchanged: only chats filed as General explicitly are silent.
Tests: common
category.test.ts(tab rule, unreplied buckets, reply moves a chat, blast copies don't count, filing moves unreads) and webInboxTabs.test.tsx. Typecheck and lint are clean on the touched files. Mobile has not been run on a device.🤖 Generated with Claude Code