Repository navigation
fix(api): drop unused strconv import - #1079
Merged
Merged
Conversation
#1078 removed the last strconv use in server.go, so the Docker build on main fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dylanjeffers
added a commit
that referenced
this pull request
Nov 12, 2026
Michael asked to stop showing listener cities: for many artists the top cities are a few non-US metros, which reads badly. The dashboard Top Cities card is already off in Optimizely (`dashboard_top_cities` Off, rev 3224). This removes the city from the weekly recap notification. - `WeeklyArtistRecapNotificationsJob` no longer computes or writes `top_city`; the week's plays scan only counts plays now. - Swagger drops the optional `top_city` field. - No client change needed: the web/mobile tile and the pedalboard push already skip the city when it's missing. - No rows exist yet (first recap is 2026-11-18), so there's no old data to handle. Also carries the one-line `strconv` import fix from #1079 so CI builds; it merges cleanly either way. `go test ./jobs/ -run WeeklyArtistRecap` passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1078 removed the last
strconvuse inapi/server.go, sogo buildand the Docker image build on main fail (run for 570f3d3). Prod is still on the 5c7465d image; nothing new deploys until this lands.go build ./...andgo vet ./api/pass.🤖 Generated with Claude Code