Portability - #685
Merged
Merged
Conversation
…eaddir/closedir instead of their Windows native equivalents
ryfactor
self-requested a review
July 31, 2026 10:24
ryfactor
reviewed
Jul 31, 2026
ryfactor
reviewed
Jul 31, 2026
ryfactor
requested changes
Jul 31, 2026
Co-authored-by: ryfactor <6005108+ryfactor@users.noreply.github.com>
Co-authored-by: ryfactor <6005108+ryfactor@users.noreply.github.com>
ryfactor
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various commits intended to improve portability, in various ways.
Note: I am cross-compiling the Windows version on Linux using
x86_64-w64-mingw32-g++. So this is 64-bit. I am not sure how to makecmakework (I am compiling using my own scripts instead which I have not included in the PR).festringandfearrayallocating anint*before the actual content and then treating it asulong, which did not work whenint*andulonghave different sizes. (Weird that this worked on Wine for me. It crashed on actual Windows though.)_findfistcrashes in w64-mingw32 (even in my minimal program) -- I have added an optionUSE_OPENDIRto use the Unix standard functionsopendir/readdirwhich work there.