Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AXIOS-15252993 - https://snyk.io/vuln/SNYK-JS-AJV-15274295 - https://snyk.io/vuln/SNYK-JS-QS-15268416
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
| "shakapacker": "6.5.5", | ||
| "terser-webpack-plugin": "5", | ||
| "terser-webpack-plugin": "5.3.11", | ||
| "view3": "https://github.com/omohokcoj/view3#motor-admin", | ||
| "vue": "^3.0.0", | ||
| "vue-loader": "^16.4.1", | ||
| "vue-router": "^4.0.0", | ||
| "webpack": "5", | ||
| "webpack-assets-manifest": "5", | ||
| "webpack": "5.98.0", | ||
| "webpack-assets-manifest": "6.0.0", | ||
| "webpack-cli": "4", | ||
| "webpack-merge": "5" | ||
| }, |
There was a problem hiding this comment.
Bug: The yarn.lock file was not updated to reflect dependency changes in package.json. This prevents the new, patched dependency versions from being installed, leaving security vulnerabilities unfixed.
Severity: CRITICAL
Suggested Fix
Run yarn install locally to regenerate the yarn.lock file based on the updated package.json. Commit the updated yarn.lock file to the pull request to ensure the correct dependency versions are installed during the build.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L8-L34
Potential issue: The `package.json` file has been updated to newer versions for several
dependencies, but the corresponding `yarn.lock` file was not updated. When `yarn
install` is executed during the build process, it will use the versions specified in the
outdated `yarn.lock` file, not the new versions from `package.json`. As a result, the
intended security patches for vulnerabilities in dependencies like `axios`, `ajv`, and
`qs` will not be applied, and the application will be deployed with the old, vulnerable
versions.
Did we get this right? 👍 / 👎 to inform future reviews.
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-AXIOS-15252993
SNYK-JS-AJV-15274295
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
🦉 Allocation of Resources Without Limits or Throttling