add code for proposals and gateways, #28
Open
bassjobsen wants to merge 2 commits intoAschPlatform:developfrom
Open
add code for proposals and gateways, #28bassjobsen wants to merge 2 commits intoAschPlatform:developfrom
bassjobsen wants to merge 2 commits intoAschPlatform:developfrom
Conversation
Contributor
|
@bassjobsen the review to your pull request: Review
1- "asch-js": "github:a1300/asch-js#fix_1_4_api",
+ "asch-js": "github:aschplatform/asch-js#develop",2You are using 3On Line 387 in Line 387 in 53e5517 4Please change the casing of all new functions in 5Please add a description to the Please change the small parts. Very good work! Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

used it with AschPlatform/asch-js#21