fix(langchain): keep content blocks of JS input messages on spans - #3820
Open
Harsh23Kashyap wants to merge 1 commit into
Open
Harsh23Kashyap wants to merge 1 commit into
Harsh23Kashyap wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3819
In the JS langchain instrumentors, a message whose
contentis an array of content blocks reaches the span with only its role. Multimodal messages,tool_resultblocks, and any other structured content record as an empty message, becausegetContentFromMessageDatakeeps string content and discards everything else.This change records each content block as a
message.contents.Nentry, in bothopeninference-instrumentation-langchainandopeninference-instrumentation-langchain-v0, which share the same parsing helper:textblocks carrymessage_content.type = "text"and their text; plain strings inside the array count as text.image_urlblocks carrymessage_content.type = "image"and their url, whether the value is a string or an object.Test plan:
should record content blocks as message contentsin test/utils.test.ts of both packages; fails on main and passes with this change.pnpm vitest run- 83 passed (langchain), 81 passed (langchain-v0), existing suites unaffected.