Conversation
The envlist entry for instructor is the only one in python/tox.ini written without its -latest sibling, while the instructor-latest install factor at python/tox.ini:217 exists. `tox -l` therefore emits no instructor -latest env, and the cron canary selects environments with `egrep -e '-latest$'`, so instructor upgrades are never exercised there. python/uv.toml:10 documents this same failure mode for a pinned dependency. Signed-off-by: fei <204683769+feiiiiii5@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
python/tox.inideclaredpy3{10,12}-ci-instructorwithout its-latestsibling, while theinstructor-latestinstall factor exists atpython/tox.ini:217. Since.github/workflows/python-cron.yamlselects canary environments withtox -l | egrep -e '-latest$', no instructor-latestenvironment was ever generated and instructor version bumps were never exercised by the canary.This adds the missing leg, keeping instructor's existing Python pair, so the envlist line matches the form used by every sibling package:
Resolves #3799
Verification
From
python/, before the change:After the change:
tox -lwas run with tox 4.56.4. No test code changed, so no suite result is claimed here; the change only makes the existinginstructor-latestfactor reachable.python/scripts/select_tox_environments.pymatches instrumentors against whole dash-delimited segments of the environment name, so both new environments still resolve to theinstructorpackage during pull-request selection.Checklist:
Note on authorship
Produced by an AI agent under this account owner's direction; the
tox -loutputs above are its own local runs. No human has reviewed the diff yet.