Repository navigation
fix(architecture-validator): clarify port dependency rule name - #290
Merged
Merged
Conversation
Owner
Author
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Owner
Author
|
🎉 This PR is included in version 4.8.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the port dependency rule to accurately state its allowed dependencies.
The rule has always allowed domain-model types, types in configured inbound/outbound port packages, and configured JDK packages. This includes concrete Command, Query, and Result DTOs stored in port packages. The old identifier incorrectly implied that only domain and JDK types were valid.
Changes:
ports_must_only_depend_on_domain_ports_or_jdk_coreValidation:
cd architecture-validator && ./gradlew clean build --no-daemon --no-build-cache --info