chore: Update directory watcher and tell ProGuard to leave it alone#87
Open
Rover656 wants to merge 2 commits intoAppliedEnergistics:mainfrom
Open
chore: Update directory watcher and tell ProGuard to leave it alone#87Rover656 wants to merge 2 commits intoAppliedEnergistics:mainfrom
Rover656 wants to merge 2 commits intoAppliedEnergistics:mainfrom
Conversation
Technici4n
reviewed
Apr 16, 2026
| -keepclassmembers class guideme.internal.hooks.mixins.* { | ||
| *; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Can you add a comment that it's because jni has a direct reference? (That's why, right?)
Member
There was a problem hiding this comment.
Do we need to keep all? How much bigger does this make the resulting jar?
Author
There was a problem hiding this comment.
Will look at how much can be stripped before it breaks, and document it's presence :)
Author
There was a problem hiding this comment.
File size difference after changing to only preserving the JNI package (which still fixes the root issue)
Before: 5,192,460 bytes (5.2 MB on disk)
After: 5,195,286 bytes (5.2 MB on disk)
…oGuard I attempted just constructors, but further funky errors were caused as a result - seems safest to just prevent the JNI package from being trimmed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MacOS directory watcher by ensuring ProGuard doesn't strip constructors used by JNI.
Also bumps the version of directory watcher as it also has MacOS JNI improvements.