Skip to content

Feat/campo plano acao - #652

Merged
robsonsobral merged 2 commits into
homolfrom
feat/campo-plano-acao
Jul 27, 2026
Merged

Feat/campo plano acao#652
robsonsobral merged 2 commits into
homolfrom
feat/campo-plano-acao

Conversation

@robsonsobral

@robsonsobral robsonsobral commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added a dedicated “Plano de Ação” input to Transferências Voluntárias forms.
    • Introduced a dedicated validation contract for Transferências Voluntárias, covering parliamentary entries and related metadata.
  • Bug Fixes

    • Improved form validation and normalization for optional fields (e.g., converting empty values to null).
    • Added/strengthened conditional validation for suspension due dates based on whether the suspension is selected.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c545811a-1ef8-4ae9-bf14-3acc38f1d7ed

📥 Commits

Reviewing files that changed from the base of the PR and between 8b4da9a and 53185d7.

📒 Files selected for processing (3)
  • frontend/src/consts/formSchemas.js
  • frontend/src/consts/formSchemas/transferenciasVoluntarias.ts
  • frontend/src/views/transferenciasVoluntarias/TransferenciasVoluntariasCriarEditar.vue

📝 Walkthrough

Walkthrough

The transferências voluntárias Yup schema moves into a dedicated TypeScript module. The form imports the new schema and adds a validated plano_de_acao input.

Changes

Transferências Voluntárias form

Layer / File(s) Summary
Dedicated validation schema
frontend/src/consts/formSchemas/transferenciasVoluntarias.ts, frontend/src/consts/formSchemas.js
Defines the transferências voluntárias validation contract, including conditional fields, nested parliamentarian data, normalization, metadata, and nullable values; removes the former shared export.
Form schema wiring and plano de acao field
frontend/src/views/transferenciasVoluntarias/TransferenciasVoluntariasCriarEditar.vue
Uses the dedicated schema module and renders the plano_de_acao field with its label and validation error message.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • AppCivico/smae#357: Both changes modify the transferências voluntárias Yup schema and its metadata.

Suggested reviewers: gustavofsoares

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the main change and points to the new plano_de_acao field feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/campo-plano-acao

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robsonsobral
robsonsobral force-pushed the feat/campo-plano-acao branch from 8b4da9a to 53185d7 Compare July 27, 2026 18:17
@robsonsobral
robsonsobral merged commit 0782118 into homol Jul 27, 2026
1 check was pending
@robsonsobral
robsonsobral deleted the feat/campo-plano-acao branch July 27, 2026 18:18
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants