Repository navigation
ci: run the check jobs on Windows beside Linux - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Run this template's CI on Windows beside Linux, so a DMS project scaffolded on Windows is known to build and pass its checks (ANT-2228). A break here reaches every new Windows DMS project.
What changes
ci.ymlpasseswindows: truetoci-node.yml@v1. The node and test jobs now also run onwindows-latest, in parallel withubuntu-latest. There was no hand-written Windows job to replace.@antelopejs/tooling-configsgoes from 0.5.4 to 0.5.8, the release that ships Windows support for the pack's checks.No Windows failure showed up, so this PR carries no fix and no new test. It adds no Windows-only skip of its own. The shared workflow itself skips
sync:checkand the compose services on Windows;sync:checkstill runs on Linux.Proof
Before, the first run with
windows: trueon tooling-configs 0.5.4 (head 349fb75): https://github.com/AntelopeJS/template-dms/actions/runs/43420235970After, on tooling-configs 0.5.8 (head 480ea75): https://github.com/AntelopeJS/template-dms/actions/runs/43420451550
Locally on Linux after the bump:
pnpm run checksgivesChecks: 9 passed, 0 failed, 1 skipped.,pnpm run sync:checkgivesGuardrails are in sync., andpnpm testexits 0.