Skip to content

ci: run the check jobs on Windows beside Linux - #17

Merged
Upd4ting merged 2 commits into
mainfrom
ci/windows
Nov 13, 2026
Merged

Upd4ting merged 2 commits into
mainfrom
ci/windows

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Why

Run this template's CI on Windows beside Linux, so a DMS project scaffolded on Windows is known to build and pass its checks (ANT-2228). A break here reaches every new Windows DMS project.

What changes

  • ci.yml passes windows: true to ci-node.yml@v1. The node and test jobs now also run on windows-latest, in parallel with ubuntu-latest. There was no hand-written Windows job to replace.
  • @antelopejs/tooling-configs goes from 0.5.4 to 0.5.8, the release that ships Windows support for the pack's checks.

No Windows failure showed up, so this PR carries no fix and no new test. It adds no Windows-only skip of its own. The shared workflow itself skips sync:check and the compose services on Windows; sync:check still runs on Linux.

Proof

Before, the first run with windows: true on tooling-configs 0.5.4 (head 349fb75): https://github.com/AntelopeJS/template-dms/actions/runs/43420235970

ci / Node .nvmrc on Windows   pass   ANTELOPEJS_CHECKS_SKIP: test,sync:check
                                     Checks: 8 passed, 0 failed, 2 skipped.
ci / Test .nvmrc on Windows   pass   > rimraf dist && tsc

After, on tooling-configs 0.5.8 (head 480ea75): https://github.com/AntelopeJS/template-dms/actions/runs/43420451550

ci / Node .nvmrc on Windows   pass   ANTELOPEJS_CHECKS_SKIP: test,sync:check
                                     Checks: 8 passed, 0 failed, 2 skipped.
ci / Test .nvmrc on Windows   pass   > rimraf dist && tsc

Locally on Linux after the bump: pnpm run checks gives Checks: 9 passed, 0 failed, 1 skipped., pnpm run sync:check gives Guardrails are in sync., and pnpm test exits 0.

@Upd4ting
Upd4ting marked this pull request as ready for review November 13, 2026 11:53
@Upd4ting
Upd4ting merged commit a5d6507 into main Nov 13, 2026
10 checks passed
@Upd4ting
Upd4ting deleted the ci/windows branch November 13, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant