docs(contributing): point contributors to the canonical fork - #92
Merged
Conversation
Surface 1 (CONTRIBUTING upstream pointer): fixed. Step 1 of the workflow still told contributors to set origin to the pre-fork git@github.com:kunchenguid/firstmate.git. It now targets git@github.com:Amplify-Logic/firstmate.git and credits kunchenguid/firstmate explicitly as the upstream this fork descends from, matching fork-surface.conf's upstream_remote declaration. Surface 2 (validation-pipeline fork target): already correct, no change. The only tracked no-mistakes configuration is .no-mistakes.yaml, which carries no push or PR target; the pipeline's push target lives in gitignored local state. git grep over tracked files finds no pipeline-target reference to the pre-fork repository. Surface 3 (PR compliance marker): already correct, no change. The marker in .github/workflows/no-mistakes-required.yml references the no-mistakes tool project (kunchenguid/no-mistakes), not the pre-fork firstmate repository, and is byte-identical to the signature the installed pipeline writes into this fork's PR bodies (verified against merged PR #91's body). Changing it would break the compliance check, and tests/no-mistakes-required-workflow.test.sh asserts the marker contract. Remaining tracked kunchenguid/firstmate references are deliberate: the new upstream-credit line in CONTRIBUTING.md, fork-surface.conf's upstream_remote declaration, an upstream-recorded verification transcript in docs/gitlab-merge-watch.md, and synthetic test-fixture URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Apply the decided repository topology corrections in this public repo. Canonical home is the fork Amplify-Logic/firstmate (origin); the original author's repo kunchenguid/firstmate is upstream. Three bounded surfaces were named, each to be investigated with git grep before editing, and any surface already correct must be documented in the commit message body rather than changed: (1) CONTRIBUTING.md still referenced the pre-fork repository as the project's home - fix references so contributors target Amplify-Logic/firstmate while crediting upstream where genuinely meant as the upstream project; (2) validation-pipeline (no-mistakes-related) configuration tracked in this repo naming the pre-fork repository as push/PR target - investigation found the only tracked config is .no-mistakes.yaml which carries no push/PR target, so this surface was already correct and no change was made; (3) PR compliance marker under .github/ - investigation found the marker in no-mistakes-required.yml references the no-mistakes TOOL project (kunchenguid/no-mistakes), not the pre-fork firstmate repo, and is byte-identical to the signature the installed pipeline writes into this fork's merged PR bodies (verified against PR #91), so changing it would break the compliance check and it was deliberately left unchanged. The one code change: CONTRIBUTING.md step 1 now targets git@github.com:Amplify-Logic/firstmate.git and adds a deliberate upstream-credit line naming kunchenguid/firstmate as the upstream this fork descends from, matching fork-surface.conf's upstream_remote. Acceptance: git grep for the pre-fork repository name over tracked files returns only deliberate upstream-credit references (fork-surface.conf upstream_remote, the new CONTRIBUTING credit line, an upstream-recorded verification transcript in docs/gitlab-merge-watch.md, synthetic test fixtures), no home-repo claims; CI stays green and workflows still run; one sentence per line in touched docs, plain dashes.
What Changed
Amplify-Logic/firstmateas the repository origin.kunchenguid/firstmateas the upstream project from which this fork descends.Risk Assessment
✅ Low: The change is a narrow documentation-only correction that matches the authoritative repository-topology intent, preserves deliberate upstream references, and introduces no material risk.
Testing
Both focused automated contracts passed, and the CLI evidence demonstrates the corrected contributor topology end to end, including a reachable canonical repository, deliberate upstream-only references, manifest validity, and documentation style; the worktree remained clean, but no remote CI run exists for the target commit.
Evidence: Contributor repository-topology transcript
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
Inspectedgit diff 3e81ed5f5fa3cce53ce3876198ff1458900802cc..a92b6f171517d0fe67c5feccf09da27c41c9bd82and the target commit message.Ranbin/fm-test-run.sh tests/fm-fork-surface.test.sh.Ranbin/fm-test-run.sh tests/no-mistakes-required-workflow.test.sh.Simulated the documented contributor workflow by extracting the SSH URL, configuring a fresh repository’sorigin, checkinggit remote -v, and resolving the canonical repository withgit ls-remote.Rangit grep -n 'kunchenguid/firstmate' -- ':!tests/*',bin/fm-fork-surface.sh check, touched-line dash/sentence checks, andgit diff --check.Queried GitHub withgh-axi run list --commit a92b6f171517d0fe67c5feccf09da27c41c9bd82 --limit 20 --fields headSha,number,updatedAt,url; no runs were present.Checked final cleanliness withgit status --short --branch.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.