Fix test298 callback-style test incompatibility with Bun#2181
Closed
Copilot wants to merge 15 commits intobun/testdriverfrom
Closed
Fix test298 callback-style test incompatibility with Bun#2181Copilot wants to merge 15 commits intobun/testdriverfrom
Copilot wants to merge 15 commits intobun/testdriverfrom
Conversation
…aram Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test 298 for error handling in plugin
Fix test298 callback-style test incompatibility with Bun
Nov 19, 2025
mathiasrw
force-pushed
the
bun/testdriver
branch
2 times, most recently
from
444b68d to
773f416
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test 298 was failing in CI with "Received function did not throw" when testing that
ECHOcommand throws before plugin is loaded.Changes
doneparameter) to synchronous tests.toThrow(Error)to.toThrow()for broader error matchingThe original pattern mixed callback-style tests with synchronous assertions, which caused Bun's test framework to not properly catch the thrown error. Removing the
doneparameter makes the test fully synchronous, allowing.toThrow()to correctly capture exceptions.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.