fix(p2p-editor): use raw file bytes and unique Hyperdrive keys for uploads#71
Open
akhileshthite wants to merge 12 commits intoAgregoreWeb:mainfrom
Open
fix(p2p-editor): use raw file bytes and unique Hyperdrive keys for uploads#71akhileshthite wants to merge 12 commits intoAgregoreWeb:mainfrom
akhileshthite wants to merge 12 commits intoAgregoreWeb:mainfrom
Conversation
RangerMauve
requested changes
Apr 30, 2025
Member
There was a problem hiding this comment.
Ty for tacking a crack at it. I was actually thinking about this recently and I think it'd be better if we did the following instead of what's there now:
- Have a "title" field used to derive the file name
- Always publish to the same IPNS/Hyper collection but under different files
- Make sure we base the styles off of
theme/style.css - Update the tutorial to reflect these changes
The benefit here is we'd have an easier time managing published sites and have an easy way to showcase all your fiddles. Should also make pinning more straightforward for those that want it.
IMO if we want to get rid of the form data method here for uploading we should do so for both protocols. In this case we're only ever uploading one file so we might as well do the simple PUT method.
Mind moving the changes to explore.md into a separate PR?
… reorder list" This reverts commit 6e61be0.
Addressed in AgregoreWeb#73
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Each publish creates a new Hyperdrive, so uploading index.html won’t overwrite the previous site.
Before:

After (ignore the styling):
