Skip to content

i18n(id): Update new strings and add new translation key#2356

Open
claycuy wants to merge 13 commits into
Acode-Foundation:mainfrom
claycuy:strings/id-lang
Open

i18n(id): Update new strings and add new translation key#2356
claycuy wants to merge 13 commits into
Acode-Foundation:mainfrom
claycuy:strings/id-lang

Conversation

@claycuy

@claycuy claycuy commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Features

  • Update new strings
    • language package completion
    • settings-info-editor-language-completion
  • Added Cursor Style Options:
    • terminal:block
    • terminal:underline
    • terminal:bar
  • Added Cursor Inactive Style Options:
    • terminal:inactive block
    • terminal:inactive underline
    • terminal:inactive bar
    • terminal:inactive none
  • Added Font Weight Options:
    • terminal:normal
    • terminal:bold
  • Added Quick Tools Options:
    • quicktools-trigger:click
    • quicktools-trigger:touch
  • Added settings-info-terminal-uninstall

note: For languages other than id-id.json I fallback to English

@github-actions github-actions Bot added the translations Anything related to Translations Whether a Issue or PR label Jun 21, 2026
@claycuy claycuy marked this pull request as ready for review June 21, 2026 04:25
@greptile-apps

greptile-apps Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR wires up i18n string lookups for terminal settings UI elements that previously used hardcoded English strings, and adds the corresponding translation keys across all 32 locale files.

  • New keys added: 13 keys covering terminal cursor styles (terminal:block/underline/bar), inactive cursor styles (terminal:inactive *), font weight labels (terminal:normal/bold), quicktools trigger labels (quicktools-trigger:click/touch), and an uninstall confirmation message (settings-info-terminal-uninstall).
  • Settings files updated: terminalSettings.js and appSettings.js now reference strings[...] for all the above instead of bare string literals; the index.d.ts type declaration is updated to match.
  • Locale coverage: id-id.json provides full native Indonesian translations; all other 31 locales fall back to English, consistent with existing practice in this repo.

Confidence Score: 5/5

Safe to merge — changes are purely additive translation key additions and mechanical string-lookup replacements with no logic or data-flow impact.

Every new string key is present in all locale files, the TypeScript type declaration is kept in sync, and the settings code correctly references the new keys. No logic is altered beyond replacing hardcoded English literals with i18n lookups.

No files require special attention.

Important Files Changed

Filename Overview
src/settings/terminalSettings.js Replaces hardcoded English strings in cursorStyle, cursorInactiveStyle, fontWeight selects, and uninstall confirmation with i18n string lookups; change is correct and complete.
src/settings/appSettings.js Quicktools trigger mode select values swapped from hardcoded "Click"/"Touch" to translated strings; functionally equivalent for English, now translatable.
src/lang/en-us.json Adds 13 new translation keys for terminal cursor styles, font weight, quicktools trigger, and uninstall confirmation; all keys are well-formed.
src/lang/id-id.json Provides native Indonesian translations for all 13 new keys plus fixes two previously untranslated entries; translations look correct.
src/lang/index.d.ts All 13 new keys added to the LangStrings TypeScript type, keeping compile-time safety in sync with the JSON data.
src/lang/ar-ye.json Representative of all 30 non-id locales: 13 new keys added with English fallbacks, consistent with the codebase's established practice for untranslated entries.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[terminalSettings.js / appSettings.js] -->|lookup strings key| B[strings object]
    B -->|loaded from| C{Active locale}
    C -->|id-id| D[id-id.json\nNative Indonesian translations]
    C -->|all other 31 locales| E[locale.json\nEnglish fallback strings]
    D & E -->|new keys| F["terminal:block/underline/bar\nterminal:inactive *\nterminal:normal/bold\nquicktools-trigger:click/touch\nsettings-info-terminal-uninstall"]
    F -->|type-checked by| G[index.d.ts LangStrings]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[terminalSettings.js / appSettings.js] -->|lookup strings key| B[strings object]
    B -->|loaded from| C{Active locale}
    C -->|id-id| D[id-id.json\nNative Indonesian translations]
    C -->|all other 31 locales| E[locale.json\nEnglish fallback strings]
    D & E -->|new keys| F["terminal:block/underline/bar\nterminal:inactive *\nterminal:normal/bold\nquicktools-trigger:click/touch\nsettings-info-terminal-uninstall"]
    F -->|type-checked by| G[index.d.ts LangStrings]
Loading

Reviews (5): Last reviewed commit: "format" | Re-trigger Greptile

Comment thread src/lang/en-us.json Outdated
Comment thread src/lang/fr-fr.json Outdated
@claycuy

claycuy commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@claycuy claycuy marked this pull request as draft June 21, 2026 04:45
@claycuy

claycuy commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@claycuy claycuy marked this pull request as ready for review June 21, 2026 12:44
@claycuy claycuy changed the title i18n: Add new translation entry i18n: Added new translation key Jun 21, 2026
@claycuy

claycuy commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Is this PR useful?

@claycuy claycuy marked this pull request as draft June 22, 2026 23:36
@UnschooledGamer

Copy link
Copy Markdown
Member

Is this PR useful?

Yeah, It won't have been if everyone knew how to read “block” from english in their own languages, but that won't be a case.

@claycuy

claycuy commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, I accidentally did a force push. Is this PR still accepted?

@claycuy claycuy marked this pull request as ready for review June 23, 2026 04:40
@claycuy claycuy changed the title i18n: Added new translation key i18n(id): Update new strings and add new translation key Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translations Anything related to Translations Whether a Issue or PR

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants