i18n(id): Update new strings and add new translation key#2356
Conversation
Greptile SummaryThis PR wires up i18n string lookups for terminal settings UI elements that previously used hardcoded English strings, and adds the corresponding translation keys across all 32 locale files.
Confidence Score: 5/5Safe to merge — changes are purely additive translation key additions and mechanical string-lookup replacements with no logic or data-flow impact. Every new string key is present in all locale files, the TypeScript type declaration is kept in sync, and the settings code correctly references the new keys. No logic is altered beyond replacing hardcoded English literals with i18n lookups. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[terminalSettings.js / appSettings.js] -->|lookup strings key| B[strings object]
B -->|loaded from| C{Active locale}
C -->|id-id| D[id-id.json\nNative Indonesian translations]
C -->|all other 31 locales| E[locale.json\nEnglish fallback strings]
D & E -->|new keys| F["terminal:block/underline/bar\nterminal:inactive *\nterminal:normal/bold\nquicktools-trigger:click/touch\nsettings-info-terminal-uninstall"]
F -->|type-checked by| G[index.d.ts LangStrings]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[terminalSettings.js / appSettings.js] -->|lookup strings key| B[strings object]
B -->|loaded from| C{Active locale}
C -->|id-id| D[id-id.json\nNative Indonesian translations]
C -->|all other 31 locales| E[locale.json\nEnglish fallback strings]
D & E -->|new keys| F["terminal:block/underline/bar\nterminal:inactive *\nterminal:normal/bold\nquicktools-trigger:click/touch\nsettings-info-terminal-uninstall"]
F -->|type-checked by| G[index.d.ts LangStrings]
Reviews (5): Last reviewed commit: "format" | Re-trigger Greptile |
|
@greptile |
|
@greptile |
|
Is this PR useful? |
Yeah, It won't have been if everyone knew how to read “block” from english in their own languages, but that won't be a case. |
|
Sorry, I accidentally did a force push. Is this PR still accepted? |
Features
language package completionsettings-info-editor-language-completionterminal:blockterminal:underlineterminal:barterminal:inactive blockterminal:inactive underlineterminal:inactive barterminal:inactive noneterminal:normalterminal:boldquicktools-trigger:clickquicktools-trigger:touchsettings-info-terminal-uninstallnote: For languages other than id-id.json I fallback to English