fix: standardize leader connection close/keepalive labels - #47
Open
rcbevans wants to merge 1 commit into
Open
Conversation
The same physical connection (deps.leader_conn) was labeled "leader" in deps.py and shutdown.py but "leader_conn" in leader.py, causing log events and metrics for one connection to appear under two different label values. Standardized to "leader" (the majority spelling) across all close_conn_bounded and apply_keepalive_to_conn call sites. Only string label literals changed; no variable names, attribute names, or function names were touched.
rcbevans
force-pushed
the
fix/leader-label-spelling
branch
from
July 30, 2026 04:58
4d25e67 to
aaae997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The same physical connection (
deps.leader_conn) was labeled "leader" indeps.pyandshutdown.pybut "leader_conn" inleader.py. This meant log events and metrics for a single connection appeared under two different label values, making it harder to correlate close/keepalive events across the codebase.Fix
Standardized to "leader" (the majority spelling) across all
close_conn_boundedandapply_keepalive_to_conncall sites inleader.py, plus the corresponding test assertions intest_leader.py.Scope
Only string label literals changed — no variable names, attribute names, or function names were touched.