feat: ParamStore::update polyfill without host push - #647
Open
kosmar wants to merge 1 commit into
Open
Conversation
Same mutate+save API as ATOVproject#640 so WIP apps can call params.update now. Host AppState push stays out until the real writeback lands. Authored by an AI coding agent on behalf of kosmar. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParamStore::updatewith the same mutate+FRAM-save call shape as feat: let apps write back their own params and notify the host #640, so WIP apps can persist on-device param edits now.AppStatepush (APP_PARAM_PUSH_CHANNEL). The configurator stays stale until the full writeback in feat: let apps write back their own params and notify the host #640 lands; swapping that in later is a drop-in on this method.Test plan
cargo clippy --bin faderpunk --target thumbv8m.main-none-eabihf -- -D warningscargo test --lib -p libfpparams.update, e.g. Manifold mode cycle): value persists across app restart; configurator still shows the old param until reconnect/pull (expected until feat: let apps write back their own params and notify the host #640)Made with Cursor