feat: add clock_ticker for apps that only need the tick count - #646
Open
ArthurGibert wants to merge 3 commits into
Open
feat: add clock_ticker for apps that only need the tick count#646ArthurGibert wants to merge 3 commits into
ArthurGibert wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
chmanie
reviewed
Aug 14, 2026
Member
There was a problem hiding this comment.
The ticks are now part of the clock events that's why it was removed earlier. See here:
faderpunk/faderpunk/src/app.rs
Line 317 in 25546b5
kosmar
added a commit
to kosmar/faderpunk
that referenced
this pull request
Aug 14, 2026
Clock::get_ticker is gone and ClockEvent::Tick carries the tick number. The app polls the counter from several places outside the clock arm, so it uses App::clock_ticker (ATOVproject#646) and takes the tick from the payload where it is already in scope. Authored by an AI coding agent on behalf of kosmar. Co-authored-by: Cursor <cursoragent@cursor.com>
10 tasks
Member
Author
|
I guess as a work-around one could still subscribe to clock events and use a global variable to share the count to the other loops. Now we just need to decide if that's how we want this case to be handled @chmanie . For context PR #644 was meant to bring back the ticker for apps that do not use the clock events: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens #644, which was merged by mistake on 2026-08-14 and then reverted from
main(force-push reset to the pre-merge commit). Same content, unchanged: three stacked commits (fix/clock-gatekeeper,feat/clock-ticker,feat/app-clock-ticker), sinceTICK_COUNTERis introduced further down the stack.See #644 for the original description and review discussion.