refactor(app): re-export LedMode so apps never import task internals - #635
Open
ArthurGibert wants to merge 2 commits into
Open
refactor(app): re-export LedMode so apps never import task internals#635ArthurGibert wants to merge 2 commits into
ArthurGibert wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App<N>facade inapp.rs, never by importingcrate::tasks::*directly — this closes the one confirmed gap in that boundary.app.rsre-exportedleds::Ledbut notleds::LedMode, even thoughLeds::set_mode()requires it — three apps (tb3po,lfo,lfo_plus) had worked around this with a directuse crate::tasks::leds::LedModeimport to use LED effects.LedModetoapp.rs's existing re-export block, and update those three apps to pull it (and, forlfo/lfo_plus,AppParams/ParamStore) throughcrate::app::only.AGENTS.mdthat any newApp<N>method taking/returning acrate::tasks::*type must re-export it in the same change, so this doesn't recur.No behavior change — this only moves import paths and widens a re-export.
Test plan
cargo fmt --all -- --check,cargo clippy --bin faderpunk --target thumbv8m.main-none-eabihf -- -D warnings,cargo clippy -p libfp -- -D warnings,cargo test --lib -p libfpall pass (already verified locally)