fix(faderpunk): eliminate false fader events from ADC noise (#556) - #628
Merged
Conversation
This reverts commit de31e32, reapplying the original #556 fix (asymmetric jitter-tolerance latch state machine + burst-median ADC read dedup). #556 was reverted (#626) because it originally merged directly to main after v1.11.0-beta.1 was already cut, skipping beta testing, with its hardware validation checklist left incomplete. Reapplying here so it can go through the process properly this time: merged well ahead of the next beta cut, with the hardware checklist actually completed before merge. Do not merge until: - v1.11.0 has fully shipped stable (not just beta) - The 5-item hardware checklist below has been completed on real hardware
ArthurGibert
force-pushed
the
reapply/pr-556-fader-adc-fix
branch
from
August 7, 2026 19:02
cd63524 to
da1805f
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies #556, previously reverted in #626.
Why this was reverted and is coming back now
#556 originally merged directly to
mainafterv1.11.0-beta.1was already cut, so it skipped the beta test cycle entirely, and its hardware validation checklist was never completed before merge. #626 reverted it sov1.11.0stable would ship on exactly what beta.1 validated.This PR reapplies the same change (verified byte-identical to the original #556 diff) so it can go through the process properly this time.
Do not merge until:
v1.11.0has fully shipped stable (not just beta —#588merged,faderpunk/v1.11.0tagged). ✅ Done.Hardware test checklist
pickup_toleranceis now 50 LSB).