Skip to content

fix(faderpunk): eliminate false fader events from ADC noise (#556) - #628

Merged
ArthurGibert merged 1 commit into
mainfrom
reapply/pr-556-fader-adc-fix
Aug 7, 2026
Merged

fix(faderpunk): eliminate false fader events from ADC noise (#556)#628
ArthurGibert merged 1 commit into
mainfrom
reapply/pr-556-fader-adc-fix

Conversation

@ArthurGibert

@ArthurGibert ArthurGibert commented Aug 6, 2026

Copy link
Copy Markdown
Member

Reapplies #556, previously reverted in #626.

Why this was reverted and is coming back now

#556 originally merged directly to main after v1.11.0-beta.1 was already cut, so it skipped the beta test cycle entirely, and its hardware validation checklist was never completed before merge. #626 reverted it so v1.11.0 stable would ship on exactly what beta.1 validated.

This PR reapplies the same change (verified byte-identical to the original #556 diff) so it can go through the process properly this time.

Do not merge until:

  • v1.11.0 has fully shipped stable (not just beta — #588 merged, faderpunk/v1.11.0 tagged). ✅ Done.
  • The hardware checklist below has actually been completed on real hardware. ✅ Done.
  • It can then merge well ahead of the next beta cut, so it rides through a full beta test cycle before reaching stable.

Hardware test checklist

  • Load a CV->MIDI layout in Jump takeover mode, patch a trigger/gate cable into an input, set all faders to mid-travel, leave faders untouched: no MIDI CC output / no value changes.
  • Fader feel in all three takeover modes (Pickup/Jump/Scale), including slow fades and fast sweeps to the end stops.
  • App-level latch takeover feel in Pickup and Scale modes (e.g. after a scene change): pickup engages at the expected proximity, no early/late latching (pickup_tolerance is now 50 LSB).
  • CV outputs (e.g. LFO app) still update smoothly (DAC write dedup now in max11300 0.5.3).
  • Layer switch (scene button) latching behaves as before.

@ArthurGibert ArthurGibert added this to the 1.12 milestone Aug 6, 2026
This reverts commit de31e32, reapplying
the original #556 fix (asymmetric jitter-tolerance latch state machine +
burst-median ADC read dedup).

#556 was reverted (#626) because it originally merged directly to main
after v1.11.0-beta.1 was already cut, skipping beta testing, with its
hardware validation checklist left incomplete. Reapplying here so it can
go through the process properly this time: merged well ahead of the next
beta cut, with the hardware checklist actually completed before merge.

Do not merge until:
- v1.11.0 has fully shipped stable (not just beta)
- The 5-item hardware checklist below has been completed on real hardware
@ArthurGibert
ArthurGibert force-pushed the reapply/pr-556-fader-adc-fix branch from cd63524 to da1805f Compare August 7, 2026 19:02
@ArthurGibert
ArthurGibert merged commit 9eb631d into main Aug 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant